[MIG] Migrate hr_contract_hourly_rate #92
Conversation
|
I will rebase after #91 will be approved. |
…lary computation selection, modify views and tests.
| [('yearly', 'Annual Wage'), | ||
| ('monthly', 'Annual Wage'), | ||
| ('hourly', 'Hourly Wage')], | ||
| string='Salary Computation Method', |
There was a problem hiding this comment.
I'm very much against changing the possible values of the fields.selection from 7.0 to 8.0; this will cause a lot of migration errors.
There was a problem hiding this comment.
I know but it's a selection fields, the options from 7.0 are still available, and from my point of view there should not be a problem...
There was a problem hiding this comment.
Yes, but the conditions below, like if contract.salary_computation_method != 'hourly': , will fail on V7 items for every case. This means that without properly migrating wage to yearly or hourly_rate to hourly, the behaviour will be different before and after migrating for every case.
Is it possible to, at least, add a comment in the README in order to describe this change in the selection? That would be enough for me to know it's documented somewhere.
|
👍 |
|
@feketemihai perfect, 👍 |
|
👍 |
[MIG] Migrate hr_contract_hourly_rate
[BSSFL-83] Invoice report initial implementation
The PR depends on #91 since the module depends on the hr_contract_multi_jobs module, ported in the pr specified.