[ADD] connector_dns #4

noahzaozao · 2016-08-29T02:55:32Z

No description provided.

noahzaozao · 2016-08-29T02:56:01Z

@elicoidal I've moved connector_dns here, please reveiw this PR.

elicoidal · 2016-08-29T03:47:36Z

connector_dns/README.rst

+
+#. Go to ...
+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas


@elicoidal How to change this line ?

Don't worry.
I will create PR change the README once it is stable enough

coveralls · 2016-08-29T06:15:11Z

Coverage remained the same at 56.463% when pulling d452aae on noahzaozao:8.0-add-connector-dns into 7c5661d on OCA:8.0.

lasley · 2016-08-29T13:52:39Z

connector_dns/__openerp__.py

+    'author': 'Elico Corp,Odoo Community Association (OCA)',
+    'license': 'AGPL-3',
+    'website': 'https://www.elico-corp.com',
+    'images': [],


Remove empty keys

lasley · 2016-08-29T14:15:07Z

Thanks for the submission @noahzaozao - comments inline. Also, can you please add test coverage? IMO this is going to be used as the base for a lot of things, so anything less than 80% is a 👎 for me - and honestly that's still pretty low.

FYI you may be able to copy a lot of testing logic from a connector I am working on. It has heavy coverage in areas where the other connectors are missing, like all of this core stuff. The Magento connector has some good tests too. Hopefully those help 😄

noahzaozao · 2016-09-30T04:04:26Z

@elicoidal Not sure how to fix the runbot warning

elicoidal · 2016-09-30T07:23:15Z

@lasley do you have any idea here how to get this rolling?

lasley · 2016-09-30T13:51:18Z

Flying to Belgium today, was planning on knocking this & prelim Docker connector out on the plane.

* Require zone in record * Fix action names in backend, zone, record * Remove states from backend and zone

lasley · 2016-10-05T13:14:24Z

All points attended to except for Settings/Connector menu is empty. Forgive my ignorance on this one, but what exactly should go in that menu?

noahzaozao/infrastructure-dns#4

hbrunn · 2016-10-08T15:36:01Z

@lasley usually, a wizard derived from ir.config.settings that allows users to configure the module. There might (I'm not very active with the connector framework) even be some base module where you can inject a checkbox to install your module from the configuration wizard

[FIX] connector_dns: Build and functional errors

coveralls · 2016-10-10T01:35:33Z

Coverage remained the same at 91.277% when pulling 7b9c230 on noahzaozao:8.0-add-connector-dns into 7c5661d on OCA:8.0.

coveralls · 2016-10-10T01:35:33Z

Coverage remained the same at 91.277% when pulling 7b9c230 on noahzaozao:8.0-add-connector-dns into 7c5661d on OCA:8.0.

lasley · 2016-10-10T16:53:42Z

Exactly what I needed, thanks @hbrunn

Will submit a new PR adding the config settings sometime this week

* Add empty group in connector settings for DNS

lasley · 2016-10-11T14:25:47Z

Added blank config view in noahzaozao/infrastructure-dns#5 - there was no need for the model at the moment because no extra modules to enable.

[ADD] connector_dns: DNS Connector settings view

coveralls · 2016-10-12T05:50:42Z

Coverage remained the same at 91.277% when pulling 4c63b75 on noahzaozao:8.0-add-connector-dns into 7c5661d on OCA:8.0.

noahzaozao · 2016-10-14T09:28:23Z

@elicoidal Once this PR has been merged , I can start re-factory the dependency modules such as connector_dnspod

noahzaozao · 2016-12-29T08:56:29Z

@elicoidal Shall we move forward with this PR ?

elicoidal · 2017-01-02T14:11:13Z

@lasley Are we good to move forward?

lasley · 2017-01-02T17:52:18Z

Yeah it would be nice to see this merged

elicoidal · 2017-01-03T11:33:55Z

@hbrunn @gurneyalex any feedback before I merge?

hbrunn · 2017-01-03T11:58:16Z

I didn't do any review, so I don't have anything to say about this PR (and it's too big to slip in a review right now). Better rely on people who actually looked at the code for a judgement, formally nobody approved it up to now...

elicoidal · 2017-01-03T12:27:02Z

@hbrunn Thanks for the quick feedback. I agree with you on both remarks :)

On my side: 👍
@lasley ?

lasley

👍 from me on the stuff I didn't write. Obviously a 👍 on the stuff I did 😉

flotho · 2017-02-04T16:27:22Z

any chance to see this PR merge ?

elicoidal · 2017-02-05T01:09:29Z

I ll merge it!

elicoidal · 2017-02-05T01:09:51Z

@noahzaozao @seb-elico

…to-oca/l10n-china [IMP]add module website_certificate.

elicoidal mentioned this pull request Aug 29, 2016

[ADD] connector_dns OCA/l10n-china#24

Closed

elicoidal reviewed Aug 29, 2016
View reviewed changes

lasley reviewed Aug 29, 2016
View reviewed changes

hbrunn added this to the 8.0 milestone Sep 26, 2016

[FIX] connector_dns: Build and functional errors

545cae2

* Require zone in record * Fix action names in backend, zone, record * Remove states from backend and zone

Merge pull request #4 from laslabs/release/8.0/connector-dns

7b9c230

[FIX] connector_dns: Build and functional errors

[ADD] connector_dns: DNS Connector settings view

33b6064

* Add empty group in connector settings for DNS

lasley mentioned this pull request Oct 11, 2016

[MIG][9.0] connector_dns #6

Open

3 tasks

Merge pull request #5 from laslabs/feature/8.0/settings

4c63b75

[ADD] connector_dns: DNS Connector settings view

noahzaozao mentioned this pull request Oct 14, 2016

[FIX] dnspod with modify, delete and list dns record from dnspod.cn OCA/l10n-china#22

Closed

lasley approved these changes Jan 3, 2017

View reviewed changes

elicoidal merged commit 7bcf645 into OCA:8.0 Feb 5, 2017

ruter-lyu pushed a commit to JoJoJoJoJoJoJo/infrastructure-dns that referenced this pull request Apr 2, 2019

Merge pull request OCA#4 from Rona111/11750-add-website-certificates-…

c51b5b5

…to-oca/l10n-china [IMP]add module website_certificate.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] connector_dns #4

[ADD] connector_dns #4

noahzaozao commented Aug 29, 2016

noahzaozao commented Aug 29, 2016

elicoidal Aug 29, 2016

noahzaozao Aug 29, 2016

elicoidal Aug 30, 2016

coveralls commented Aug 29, 2016 •

edited

lasley Aug 29, 2016

lasley commented Aug 29, 2016

noahzaozao commented Sep 30, 2016

elicoidal commented Sep 30, 2016

lasley commented Sep 30, 2016

lasley commented Oct 5, 2016 •

edited

hbrunn commented Oct 8, 2016

coveralls commented Oct 10, 2016

coveralls commented Oct 10, 2016

lasley commented Oct 10, 2016

lasley commented Oct 11, 2016

coveralls commented Oct 12, 2016 •

edited

noahzaozao commented Oct 14, 2016 •

edited

noahzaozao commented Dec 29, 2016

elicoidal commented Jan 2, 2017

lasley commented Jan 2, 2017

elicoidal commented Jan 3, 2017

hbrunn commented Jan 3, 2017

elicoidal commented Jan 3, 2017

lasley left a comment

flotho commented Feb 4, 2017

elicoidal commented Feb 5, 2017

elicoidal commented Feb 5, 2017


		#. Go to ...

		.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas

[ADD] connector_dns #4

[ADD] connector_dns #4

Conversation

noahzaozao commented Aug 29, 2016

noahzaozao commented Aug 29, 2016

elicoidal Aug 29, 2016

Choose a reason for hiding this comment

noahzaozao Aug 29, 2016

Choose a reason for hiding this comment

elicoidal Aug 30, 2016

Choose a reason for hiding this comment

coveralls commented Aug 29, 2016 • edited

lasley Aug 29, 2016

Choose a reason for hiding this comment

lasley commented Aug 29, 2016

noahzaozao commented Sep 30, 2016

elicoidal commented Sep 30, 2016

lasley commented Sep 30, 2016

lasley commented Oct 5, 2016 • edited

hbrunn commented Oct 8, 2016

coveralls commented Oct 10, 2016

coveralls commented Oct 10, 2016

lasley commented Oct 10, 2016

lasley commented Oct 11, 2016

coveralls commented Oct 12, 2016 • edited

noahzaozao commented Oct 14, 2016 • edited

noahzaozao commented Dec 29, 2016

elicoidal commented Jan 2, 2017

lasley commented Jan 2, 2017

elicoidal commented Jan 3, 2017

hbrunn commented Jan 3, 2017

elicoidal commented Jan 3, 2017

lasley left a comment

Choose a reason for hiding this comment

flotho commented Feb 4, 2017

elicoidal commented Feb 5, 2017

elicoidal commented Feb 5, 2017

coveralls commented Aug 29, 2016 •

edited

lasley commented Oct 5, 2016 •

edited

coveralls commented Oct 12, 2016 •

edited

noahzaozao commented Oct 14, 2016 •

edited