[MIG] document_url port v10 #111

difusionvisual · 2016-11-15T17:21:50Z

No description provided.

oca-clabot · 2016-11-15T17:21:51Z

Hey @difusionvisual, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Nicolás (no github login found)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2016-11-15T17:28:32Z

Have you signed the CLA?

antoniocanovas · 2016-11-15T22:27:57Z

This user is included in the "Entity CLA" "Serincloud S.L." few days ago.
Must he sign it again as single user?

Un saludo,

   Antonio Cánovas Pedreño

antonio.canovas@ingenieriacloud.com
Teléfono.- 6224.2.6224

    Twitter.- @acanovasp http://www.twitter.es/acanovasp*

2016-11-15 18:28 GMT+01:00 Pedro M. Baeza notifications@github.com:

Have you signed the CLA?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#111 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH7_yVnUbPHkNA_WNS1e2iIK7M8iu5sdks5q-evIgaJpZM4Kyy0h
.

http://www.konery.es
Antes de imprimir este e-mail piense bien si es necesario, la conservación
del medio ambiente es tarea de todos.
Este mensaje contiene información CONFIDENCIAL sometida a secreto
profesional. Si lo ha recibido por error, debe saber que la copia, uso o
divulgación están prohibidos la Ley, por ello, le rogamos que nos lo
comunique por esta misma vía y proceda a su destrucción.

Muchas gracias.

antoniocanovas · 2016-11-16T19:55:33Z

Functionality LGFM

pedrobaeza · 2016-11-16T19:56:08Z

Use the new approval system (in the third tab)

antoniocanovas

Functionality LGFM

rafaelbn · 2016-11-17T07:07:32Z

Thanks for this contribution, please check travis it fails

pedrobaeza

Change 9.0 to 10.0 in https://github.com/OCA/knowledge/pull/111/files#diff-aea8538352c095a1b0f3280f36aca520R26
Use new README template: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

pedrobaeza · 2016-11-17T07:53:07Z

document_url/wizard/document_url.py

            url = urlparse(form.url)
            if not url.scheme:
                url = urlparse('%s%s' % ('http://', form.url))
-            for active_id in context.get('active_ids', []):
+            for active_id in self._context.get('active_ids', []):


Use self.env.context instead.

difusionvisual · 2016-11-17T23:26:21Z

Fixed review

pedrobaeza · 2016-11-18T09:02:48Z

document_url/static/src/xml/url.xml

+            </li>
+        </t>
+    </t>
+</templates>


Line at the end.

pedrobaeza · 2016-11-18T09:03:04Z

document_url/README.rst

-* Pedro M. Baeza <pedro.baeza@tecnativa.com
+* Pedro M. Baeza <pedro.baeza@tecnativa.com>
+* Nicolás Ramos <contacto@difusionvisual.com>
+* Antonio Cánovas <antonio.canovas@ingenieriacloud.com>


Non developers shouldn't go here as contributors.

This happens a lot - Do you think a note in the contribution guidelines would be worthy?

Well, sometimes a "designer" can be put here, because he/she has contributed in the design of the module, but I know the history of this module (I developed it initially for him), and there's no contribution except the financial one. The line here is thin, so it's difficult to reflect in a guideline...

I have created a PR to improve the template to add the possibility of defining funders: OCA/maintainer-tools#241

pedrobaeza · 2016-11-18T09:03:45Z

document_url/wizard/document_url.py

                    'res_id': active_id,
-                    'res_model': context['active_model'],
+                    'res_model': context.get('active_model')


Why you change this? Is correct as is.

pedrobaeza · 2016-11-18T09:14:05Z

Tried on runbot and working.

sbidoul · 2017-02-22T13:38:41Z

@difusionvisual I got the following error on runbot:

Can you have a look?

dreispt · 2017-03-21T22:59:25Z

document_url/static/src/js/url.js

- *                      Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
- * © 2016 ACSONE SA/NV (<http://acsone.eu>)
- * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
- */


Don't remove copyrights

dreispt · 2017-03-21T23:01:21Z

document_url/wizard/document_url.py

-        if not context.get('active_model'):
+
+        context = self.env.context
+        if not context['active_model']:


Keep the original context.get - the new form will error if the looked up key is not found in the context.

dreispt · 2017-03-21T23:03:09Z

document_url/wizard/document_url.py

            url = urlparse(form.url)
            if not url.scheme:
                url = urlparse('%s%s' % ('http://', form.url))
-            for active_id in context.get('active_ids', []):
+            for active_id in context['active_ids', []]:


Keep the context.get().
That's the cause of the error found by @sbidoul

dreispt · 2017-03-21T23:05:18Z

document_url/wizard/document_url.py

-                attachment_obj.create(cr, uid, attachment, context=context)
-        return {'type': 'ir.actions.act_close_wizard_and_reload_view'}
+                attachment_obj.create(attachment)
+        return False


Why is the return value now empty?

I don't understand why this action repoen the wizard is it a "quick next encode"? I agree with @difusionvisual to replace this by return false...

It was because in older versions of Odoo, it didn't refresh the view and you didn't see the new attachment number. I don't know if this happens also in v10.

sbidoul · 2017-04-23T20:31:06Z

@nicolasramos do you plan to finish this one?

JonathanNEMRY · 2017-05-22T10:05:58Z

waiting merge of https://github.com/ingenieriacloud/knowledge/pull/2 with changes of @dreispt

Bilbonet

I've tried the module in my v10 and works fine.

pedrobaeza · 2018-08-17T19:12:05Z

Travis is still red

Bilbonet · 2018-08-21T17:44:13Z

For Travis only need minimal changes in two files.
url.js > Remove comma in lines 16, 17, 18 ,28
wizard/document_url.py > Remove import 'odoo._' is not used

I have the Travis ok with only this changes:
https://travis-ci.com/Bilbonet/knowledge/builds/82463764

Initial review too old.

hbrunn · 2018-10-20T14:05:23Z

superseded by #192

[MIG]Port v10

f1040fb

no message

3c0ed6b

pedrobaeza mentioned this pull request Nov 15, 2016

Migration to version 10.0 #105

Closed

12 tasks

nicolasramos added 5 commits November 15, 2016 22:45

Fix update attachment

65e4a19

Fix Url sidebar

6caf5e7

Delete css

34e0bb4

Fix and tested

b74597d

Change version to 10

00df69a

antoniocanovas approved these changes Nov 16, 2016

View reviewed changes

pedrobaeza requested changes Nov 17, 2016

View reviewed changes

pedrobaeza reviewed Nov 17, 2016

View reviewed changes

Fixed review

a63f0b3

pedrobaeza reviewed Nov 18, 2016

View reviewed changes

document_url/static/src/xml/url.xml Outdated

</li>

</t>

</t>

</templates>

Copy link

Member

pedrobaeza Nov 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line at the end.

pedrobaeza reviewed Nov 18, 2016

View reviewed changes

Fixed review

ea8ebcd

hbrunn added this to the 10.0 milestone Jan 11, 2017

hbrunn added the needs fixing label Jan 11, 2017

eugen-don mentioned this pull request Feb 19, 2017

Need help to install on odoo comunity 10 #114

Closed

max3903 mentioned this pull request Mar 15, 2017

Module Knowledge Odoo v10....need help #126

Closed

dreispt previously requested changes Mar 21, 2017

View reviewed changes

Apply changes

b5961b8

pedrobaeza mentioned this pull request Apr 29, 2018

document_url: Fix inclusion of unknown field 'user_id' #166

Closed

Bilbonet approved these changes Aug 17, 2018

View reviewed changes

Bilbonet mentioned this pull request Sep 29, 2018

[MIG] document_url to v10 #191

Closed

Bilbonet mentioned this pull request Oct 1, 2018

[MIG] document_url to v10 #192

Closed

hbrunn closed this Oct 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] document_url port v10 #111

[MIG] document_url port v10 #111

difusionvisual commented Nov 15, 2016

oca-clabot commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

antoniocanovas commented Nov 15, 2016

antoniocanovas commented Nov 16, 2016 •

edited

Loading

pedrobaeza commented Nov 16, 2016

antoniocanovas left a comment

rafaelbn commented Nov 17, 2016

pedrobaeza left a comment

pedrobaeza Nov 17, 2016

difusionvisual commented Nov 17, 2016

pedrobaeza Nov 18, 2016

pedrobaeza Nov 18, 2016

lasley Nov 18, 2016

pedrobaeza Nov 18, 2016

pedrobaeza Nov 18, 2016

pedrobaeza Nov 18, 2016

pedrobaeza commented Nov 18, 2016

sbidoul commented Feb 22, 2017

dreispt Mar 21, 2017

dreispt Mar 21, 2017

dreispt Mar 21, 2017

dreispt Mar 21, 2017

JonathanNEMRY May 22, 2017

pedrobaeza May 22, 2017

sbidoul commented Apr 23, 2017

JonathanNEMRY commented May 22, 2017

Bilbonet left a comment

pedrobaeza commented Aug 17, 2018

Bilbonet commented Aug 21, 2018

hbrunn commented Oct 20, 2018

[MIG] document_url port v10 #111

[MIG] document_url port v10 #111

Conversation

difusionvisual commented Nov 15, 2016

oca-clabot commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

antoniocanovas commented Nov 15, 2016

antoniocanovas commented Nov 16, 2016 • edited Loading

pedrobaeza commented Nov 16, 2016

antoniocanovas left a comment

Choose a reason for hiding this comment

rafaelbn commented Nov 17, 2016

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

difusionvisual commented Nov 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 18, 2016

sbidoul commented Feb 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbidoul commented Apr 23, 2017

JonathanNEMRY commented May 22, 2017

Bilbonet left a comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 17, 2018

Bilbonet commented Aug 21, 2018

hbrunn commented Oct 20, 2018

antoniocanovas commented Nov 16, 2016 •

edited

Loading