[12.0][IMP] l10n_br_fiscal: tax.py - remove discount from tax base value #1519

marcelsavegnago · 2021-07-14T21:25:16Z

cc @renatonlima @bmessiaz

rvalyi · 2021-07-14T22:34:36Z

socorro, soltaram o Github co-pilot no projeto!

;-p

marcelsavegnago · 2021-07-14T22:42:43Z

socorro, soltaram o Github co-pilot no projeto!

;-p

hahahahahah rascunho ainda

renatonlima · 2021-07-20T13:28:26Z

@marcelsavegnago Eu fiz dois PRs #1530 e #1531 que vai ajudar a testar esse PR.

mileo · 2021-07-27T10:21:59Z

@marcelsavegnago sempre tem muita discussão em cima do desconto na base de cálculo, qualquer google sobre isso vai ter várias referências para ambos os lados:

http://www.amakan.com.br/boletim/base-de-calculo-do-icms-desconto-incondicional-114#:~:text=Base%20de%20C%C3%A1lculo%20do%20ICMS%20%2D%20Descontos%20Incondicionais,base%20de%20c%C3%A1lculo%20do%20imposto.

https://www.conjur.com.br/2017-fev-22/consultor-tributario-descontos-incondicionados-nao-integram-base-calculo-icms

@bmessiaz alguma opinião sobre?

Desconto deve reduzir a base de cálculo de todos os impostos ou só alguns?

bmessiaz · 2021-07-27T11:18:54Z

@mileo @marcelsavegnago

                                       Regra: (legislação/ICMS/PIS/COFINS/IPI/ISS)

                                       1) Desconto Incondicional, "Afeta" a base de cálculo do Imposto  ao se emitir a NF.
                                       2) Desconto Condicional, "Não Afeta" a base de cálculo do imposto ao se emitir a NF.


                                      Att,

                                       @bmessiaz

marcelsavegnago · 2021-08-27T19:49:10Z

@marcelsavegnago Eu fiz dois PRs #1530 e #1531 que vai ajudar a testar esse PR.

@renatonlima Não lembro se já tinha feito um rebase para considerar estas PRs, massss... fiz um rebase agora.

@felipemotter e @netosjb se puderem revisar e testar eu agradeço.

felipemotter · 2021-08-28T13:57:54Z

Assim que conseguir vou dar uma olhada.

marcelsavegnago · 2021-09-14T22:07:26Z

l10n_br_fiscal/models/tax.py

@@ -401,7 +372,8 @@ def _compute_icms(self, tax, taxes_dict, **kwargs):
            company.state_id != partner.state_id
            and operation_line.fiscal_operation_type == FISCAL_OUT
            and partner.ind_ie_dest == NFE_IND_IE_DEST_9
-            and taxes_dict[tax.tax_domain].get("tax_value")
+            and not partner.is_company


@renatonlima este not partner.is_company está certo ?

antoniospneto

teste funcional + code review 👍🏻

antoniospneto · 2021-10-04T02:29:38Z

@marcelsavegnago
O erro do Trevis deve ser o que foi solucionado na PR #1639
Um novo rebase deve resolver.

felipemotter

Tem que dar uma olhada no Travis, mas ta OK.

rvalyi · 2021-10-12T12:08:24Z

@renatonlima OK pro merge desse?

renatonlima

Para fazer o merge desse PR é necessário apenas fazer uma correção:

Adicionar um campo boolean no objeto l10n_br_fiscal.tax.group para indicar se a base de calculo do imposto é adicionado os valores de fretes, seguro e outras despesas;
Alterar o arquivo de dados que carregam os l10n_br_fiscal.tax.group para definir o ICMS, ICMS ST para adicionar na base de calculo os valores de fretes, seguro e outras despesas;

felipemotter · 2022-06-07T01:02:55Z

@marcelsavegnago Pode fazer um rebase?

marcelsavegnago · 2022-06-11T14:32:23Z

@felipemotter posso cancelar esta PR ?

antoniospneto · 2022-06-11T14:56:00Z

@marcelsavegnago pode sim, os commits foram todos incluídos no merge do #1963 , valeu!

marcelsavegnago mentioned this pull request Jul 14, 2021

[12.0][BUG] l10n_br_fiscal: soma dos impostos retidos #1514

Closed

marcelsavegnago force-pushed the 12.0-l10n_br_fiscal-remove_discount_from_tax_base_value branch from 02bb31e to 8d972ff Compare August 5, 2021 19:27

marcelsavegnago force-pushed the 12.0-l10n_br_fiscal-remove_discount_from_tax_base_value branch from a984881 to 6fb9490 Compare August 27, 2021 19:46

marcelsavegnago marked this pull request as ready for review August 27, 2021 19:47

rvalyi added the needs review label Aug 31, 2021

marcelsavegnago commented Sep 14, 2021

View reviewed changes

marcelsavegnago force-pushed the 12.0-l10n_br_fiscal-remove_discount_from_tax_base_value branch from 6fb9490 to 3e7c36d Compare September 14, 2021 22:11

antoniospneto approved these changes Oct 4, 2021

View reviewed changes

marcelsavegnago and others added 3 commits October 4, 2021 20:21

[IMP] l10n_br_fiscal: tax.py - remove discount from tax base value

7e5e27f

[REF] _compute_tax_base to implements add_to_base and remove_from_base

03b7bfe

[FIX] pre-commit

68d9f7f

marcelsavegnago force-pushed the 12.0-l10n_br_fiscal-remove_discount_from_tax_base_value branch from 3e7c36d to 68d9f7f Compare October 4, 2021 23:22

felipemotter approved these changes Oct 5, 2021

View reviewed changes

OCA-git-bot added the approved label Oct 5, 2021

antoniospneto mentioned this pull request Oct 6, 2021

[12.0][FIX] Número da rua no cadastro de parceiros. #1651

Merged

renatonlima requested changes Oct 13, 2021

View reviewed changes

OCA-git-bot removed the approved label Oct 13, 2021

marcelsavegnago added the needs fixing label Nov 7, 2021

marcelsavegnago marked this pull request as draft November 7, 2021 22:27

antoniospneto mentioned this pull request Jun 7, 2022

[12.0][FIX] Valor base dos impostos #1963

Merged

marcelsavegnago closed this Jun 11, 2022

marcelsavegnago deleted the 12.0-l10n_br_fiscal-remove_discount_from_tax_base_value branch June 11, 2022 17:21

hirokibastos mentioned this pull request Aug 4, 2022

[12.0] l10n_br_fiscal: Arruma condição para aplicação do Difal #2065

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][IMP] l10n_br_fiscal: tax.py - remove discount from tax base value #1519

[12.0][IMP] l10n_br_fiscal: tax.py - remove discount from tax base value #1519

marcelsavegnago commented Jul 14, 2021 •

edited

rvalyi commented Jul 14, 2021 •

edited

marcelsavegnago commented Jul 14, 2021 •

edited

renatonlima commented Jul 20, 2021

mileo commented Jul 27, 2021

bmessiaz commented Jul 27, 2021

marcelsavegnago commented Aug 27, 2021

felipemotter commented Aug 28, 2021

marcelsavegnago Sep 14, 2021

antoniospneto left a comment

antoniospneto commented Oct 4, 2021

felipemotter left a comment

rvalyi commented Oct 12, 2021

renatonlima left a comment

felipemotter commented Jun 7, 2022 •

edited

marcelsavegnago commented Jun 11, 2022

antoniospneto commented Jun 11, 2022

[12.0][IMP] l10n_br_fiscal: tax.py - remove discount from tax base value #1519

[12.0][IMP] l10n_br_fiscal: tax.py - remove discount from tax base value #1519

Conversation

marcelsavegnago commented Jul 14, 2021 • edited

rvalyi commented Jul 14, 2021 • edited

marcelsavegnago commented Jul 14, 2021 • edited

renatonlima commented Jul 20, 2021

mileo commented Jul 27, 2021

bmessiaz commented Jul 27, 2021

marcelsavegnago commented Aug 27, 2021

felipemotter commented Aug 28, 2021

marcelsavegnago Sep 14, 2021

Choose a reason for hiding this comment

antoniospneto left a comment

Choose a reason for hiding this comment

antoniospneto commented Oct 4, 2021

felipemotter left a comment

Choose a reason for hiding this comment

rvalyi commented Oct 12, 2021

renatonlima left a comment

Choose a reason for hiding this comment

felipemotter commented Jun 7, 2022 • edited

marcelsavegnago commented Jun 11, 2022

antoniospneto commented Jun 11, 2022

marcelsavegnago commented Jul 14, 2021 •

edited

rvalyi commented Jul 14, 2021 •

edited

marcelsavegnago commented Jul 14, 2021 •

edited

felipemotter commented Jun 7, 2022 •

edited