New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separada visão de faturas com a visão de documentos fiscais #363
Conversation
44a4e20
to
592e046
Compare
9b61f7d
to
c0ded07
Compare
@mileo @danimaribeiro @mbcosta @rvalyi Este PR esta concluído, podem fazer o review, eu vi que teve uma baixa no coverage do código, mas eu acredito que isso seja causado pela remoção dos métodos fieds_view_get do account.invoice e account.invoice.line, hoje pela manhã é bem provável que eu faça algumas melhorias das visões tree e search da NFe para melhorar a ergonomia. |
uma nota importante: apesar de ser grande esse PR nao altera a estrutura do banco de dados, um simples --update=all deve dar conta. A unica coisa e aue o @renatonlima redefiniu o campo purchase_ok do core para que ele nao faltasse caso o modulo purchase nao fosse installado, porque isso e um bug do core que foi reportado aqui odoo/odoo#13271 |
@renatonlima acredito que está faltando ou um filtro para se poder separar as Notas dos Fornecedores ou Clientes ou separar as visões de NFe de Entradas e de Saídas. Dependendo da quantidade de notas e de como a empresa funciona mistura-las acaba sendo ruim para visualização do usuário final. |
👎 @renatonlima so you moved the account_invoice_workflow.xml extension into the l10n_br_account module. This is great but currently this doesn't seem correct the way it is. Indeed, in account_invoice_workflow.xml you call the check_nfe() method which is defined only in the l10n_br_account_product module. Same for the sefaz_export invoice state: it is defined only in l10n_br_account_product. I'm not sure what is better: either define these things in the l10n_br_account module or either override the workflow again where it makes sense again in the l10n_br_account_product module. Don't get me wrong the rest of the work is absolutely awesome, just found this issue so far... |
|
@renatonlima Revisando com mais calma, ao meu ver o fluxo ainda esta incompleto:
👎 A user experiencie muito ruim. Não consegui detectar uma lógica de uso na alterações feitas. Temos que pensar em uma solução. se quiser podemos fazer um hangout. []s |
Neste PR ainda falta finalizar o fluxo das actions que abrem a fatura, neste caso, se você tiver em venda ou compras que gerou uma NFe, deveria cair na visão de NFe. Também tem um problema no workflow da invoice. Daqui a pouco eu devo subir alguns commits para resolver isso, eu também vou fazer um vídeo para explicar um pouco o conceito, eu passei o PR para WIP |
Outra coisa bacana, seria deixar a visão parecida com o DANFE. Mas tem que ver o quanto isto é possível. |
7bc11fa
to
fe6e18d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatonlima I restarted the job after the DNS issue was gone but there are still some issues
@mileo: about the change being large and as it was just discussed here: OCA/pylint-odoo#59 (comment) Well in the OCA projects we do make some important changes within a "stable" Odoo release and unlike the Odoo SA release policy, may be because we can develop only once Odoo version stabilize and it's really iterative as being aggressively open source there is little to no up-front investment in the OCA work. So for instance some changes requires to run with --update as they change the schema (not the case here). Today the OCA is NOT an end user distribution. May be it may become one as things stabilize but it's not the case today and it would be populism to present it as such. So system integrators building upon the OCA have the responsibility to upgrade or not (we really don't always blindly upgrade our OCA dependencies in a project).
Now @mileo you got a point, @renatonlima when doing this we should increment the 'x' of the module version number 8.0.x.y.z as specified by the OCA guideline: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers
Today this is just an information but eventually if the OCA package management make significant progress in the future, that may ease automatic-upgrades so this is a discipline we should enforce.
@@ -94,6 +94,7 @@ def _default_fiscal_category(self): | |||
|
|||
@api.model | |||
def _default_fiscal_document(self): | |||
import pudb; pudb.set_trace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gah, you committed with pudb!
…ght account.invoice view
c23df73
to
4fd577f
Compare
4fd577f
to
d4086b1
Compare
👍 |
ok, enough time on this PR, we got approvals from @mileo and me and work from @renatonlima who wrote 70%+ of the current repo codebase. Constructive and detailed criticisms had enough time to be opposed. We cannot just accept something like "it needs to be completely different", without detailed argumentation and specially not like 4 months after this PR started and not for a such radical change in v8. I hope that everybody understands that we now need to move forward to address the 9 and 10 series too where we will be more open to progressive design changes coming along with proper migration scripts within their series. |
@rvalyi O @renatonlima concluiu aquela alteração, dos "botões"? |
Olá pessoal, Eu fiz as mudanças para retirar o domain das actions das faturas e adicionar um botão na list view form view para ir ao documento eletrônico, havia um problema no domain de um campo que concertei agora pouco no ultimo commit, acredito que agora esta ok. |
👍 ok next fixes in new PR's if required, seems all right and far better than before already. |
No description provided.