Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][MIG] l10n_br_stock_account #706

Merged
merged 22 commits into from Sep 11, 2019
Merged

[10.0][MIG] l10n_br_stock_account #706

merged 22 commits into from Sep 11, 2019

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Aug 14, 2019

Replace #640 to use a common repository.

Depends OCA/account-fiscal-rule#90

WIP - Procurement

cc @renatonlima @rvalyi @mileo

@mbcosta mbcosta force-pushed the 10.0-mig-l10n_br_stock_account branch from ab0598b to 2982291 Compare August 14, 2019 20:42
@rvalyi rvalyi mentioned this pull request Aug 15, 2019
Closed
@rvalyi
Copy link
Member

rvalyi commented Aug 30, 2019

OCA/account-fiscal-rule#90 has been merged. This should be rebased to avoid the postgres error with .travis.yml.

@rvalyi rvalyi force-pushed the 10.0-mig-l10n_br_stock_account branch from 2982291 to 3e50661 Compare August 30, 2019 21:54
@rvalyi
Copy link
Member

rvalyi commented Aug 30, 2019

I just did the rebase on 10.0, let's see the tests now...

@renatonlima
Copy link
Member

I think the pot translation file is missing

renatonlima
renatonlima requested changes Sep 2, 2019
View reviewed changes
l10n_br_stock_account/__manifest__.py Outdated
'depends': [
'l10n_br_account_product',
'l10n_br_stock',
'account_fiscal_position_rule_stock',
'stock_account',
'sale_stock',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta dependência deveria estar no módulo l10n_br_sale_stock. https://github.com/OCA/l10n-brazil/blob/10.0/l10n_br_sale_stock/__manifest__.py#L14

l10n_br_stock_account/views/stock_view.xml
</field>
</record>

<!--<record model="ir.ui.view" id="l10n_br_stock_account_procurement_rule_inherit_form">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover estes comentários

l10n_br_stock_account/wizard/stock_invoice_onshipping.py Outdated
comment = ''
if picking.fiscal_position_id.inv_copy_note:
comment += picking.fiscal_position_id.note or ''
if picking.sale_id and picking.sale_id.copy_note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta parte deste código deveria estar no módulo l10n_br_sale_stock

l10n_br_stock_account/demo/l10n_br_stock_account_demo.xml Outdated
<field name="fiscal_category_id" ref="l10n_br_account_product.fc_86d8c770fc2fb9d9fa242a3bdddd507a"/>
</record>

<!-- Picking Test - 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover comentários

@mbcosta mbcosta force-pushed the 10.0-mig-l10n_br_stock_account branch from 284c091 to 56e63f8 Compare September 6, 2019 19:52
@renatonlima
Copy link
Member

Kudos @mbcosta!

@mbcosta
Copy link
Contributor Author

mbcosta commented Sep 9, 2019 •
edited

Thanks @renatonlima for review

@renatonlima
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-706-by-renatonlima-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 11, 2019
@OCA-git-bot
Merge PR #706 into 10.0
e0acb3c 
Signed-off-by renatonlima
@OCA-git-bot OCA-git-bot merged commit 2a80e77 into OCA:10.0 Sep 11, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1b62878. Thanks a lot for contributing to OCA. ❤️

@mileo mileo deleted the 10.0-mig-l10n_br_stock_account branch September 12, 2019 13:07
@mbcosta
Copy link
Contributor Author

mbcosta commented Sep 12, 2019

Hi @gabrielcardoso21 , thanks by review

OCA-git-bot pushed a commit that referenced this pull request Feb 4, 2023
@lfdivino
Merge pull request #706 from kmee/14.0_extract_l10n_br_pos_remove_att…
ceb15e4 
…achment

[REM] Non necessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatonlima renatonlima renatonlima approved these changes

@gabrielcardoso21 gabrielcardoso21 gabrielcardoso21 approved these changes

Assignees
No one assigned
Labels
10.0 approved merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mbcosta @rvalyi @renatonlima @OCA-git-bot @gabrielcardoso21 @mileo @BiancaBartolomei