[FIX] Port nationality code to res_country #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Issue: #739 |
renatonlima
approved these changes
Oct 21, 2019
rvalyi
approved these changes
Oct 22, 2019
mileo
requested changes
Oct 22, 2019
There was a problem hiding this comment.
Os dados da tabela l10n_br_hr/data/hr_employee_nationality_code_data.xml não deveriam ser inseridos no l10n_br_base, seja no próprio módulo ou através do módulo do l10n_br_hr?
Então creio que a modificação poderia ser efetuada apenas no l10n_br_hr, removendo a tabela e extendendo o res.contry
mileo
approved these changes
Oct 23, 2019
|
@hendrixcosta pode resolver o conflito para fazermos o merge? |
hendrixcosta
force-pushed
the
feature/port-codigo-nacional
branch
from
be10df0
to
cc94d77
Compare
hendrixcosta
force-pushed
the
feature/port-codigo-nacional
branch
from
cc94d77
to
220755a
Compare
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 23, 2019
|
Congratulations, your PR was merged at f10590c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.