Add Croatia cities and states #2
Conversation
l10n_hr_base_location/README.rst
Outdated
| Izvor: | ||
|
|
||
| Croatian counties (without HR- prefix in code) https://en.wikipedia.org/wiki/ISO_3166-2:HR | ||
| Hr Pošta webstranice |
There was a problem hiding this comment.
It is relevant for the description to be also in english. Could you add that please?
There was a problem hiding this comment.
No problem, added these files, as i saw in spain localization, lots of readme files was only in spanish, so i thought for localizations descriptions are allowed to be only in local language,
from now on i will try to write all the explanations and readmes in english.
There was a problem hiding this comment.
In localization repos, README can be in native language.
| --> | ||
|
|
||
| <record id="state_hr_01" model="res.country.state"> | ||
| <field name="country_id" ref="base.hr"/> |
There was a problem hiding this comment.
Can you also add the Country?
| @@ -0,0 +1 @@ | |||
| __import__('pkg_resources').declare_namespace(__name__) | |||
There was a problem hiding this comment.
Not wrong, but there is no need to have the trouble to add these files: they will be automatically generated by an OCA bot.
There was a problem hiding this comment.
Tnx for pointing out this part... wasn't sure if this will be automatic or not so i added it in first commit, and repeated in this one..
Will ommit this in future.
|
I'm seeing that Geonames includes all these names: http://download.geonames.org/export/dump/HR.zip. You can use base_location_geonames_import module as base the same as we do with l10n_es_toponyms for avoiding to need this bunch of data. |
|
@pedrobaeza tnx for pointing geonames... |
|
In |
|
my reason for makin this module, is this way we have imported data with proper ids, that can be called as reference in other modules that adds some other specific coding, so i assumed easier to reference on static triple checked data end extend them using thopse defined ids. also, I saw a lot of simmilar modules in other localizations, (swiss, germany, argentina, france) addins states, and some of them add cities... also i'm aware that these modules are ported from older versions, before base_geonames_import module was introduced... |
|
@pedrobaeza i have done some testig as you proposed. Conclusion: I would still like to merge this pull request, based on these arguments, data from module is minimized and triple checked to be compliant with post current codes. |
|
OK for me too. Proceed with the merge. |
|
excelent! tnx for help, merging this one. |
No description provided.