Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 account balance ebp csv export #19

Merged
merged 10 commits into from
Aug 25, 2015

Conversation


This module adds a button *EBP csv File* next to the *Print* button on the Trial Balance wizard. The aim is to export the trial balance to software dedicated to the *Liasse fiscale* (French fiscal declaration) that accept CSV files from the popular EBP accounting software. This file has been tested with Teledec (https://www.teledec.fr/), which is a SaaS solution for the *Liasse fiscale* with support for EDI transmission.

This module has been developped by Alexis de Lattre from Akretion <alexis.delattre@akretion.com>.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to explain what this module has to do with EBP software packages (that is, "practically nothing" if I understand correctly).
Can you please update the description to use the OCA template too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clonedagain I think you mis-understood what this module does. This module doesn't implement a file for the liasse fiscale. It implements the file format of a balance export of the EBP software. This is a trick that we use to be able to export a balance to the liasse fiscale software, because almost all liasse fiscale software accept EBP balance export files as input.

So this module is NOT directly linked to liasse fiscale, it is linked to the EBP balance export.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I'll comment again when the description gives sufficient
details about what it's for and how to use it.

@clonedagain
Copy link

The module's name is poorly chosen - users would expect a module with "EBP" and "export" in it's name to be able to export data to EBP's accounting software packages (something like https://github.com/numerigraphe/numerigraphe-addons/tree/7.0/account_export_ebp).
If I understand correctly, it's just incidental that the simplest file format accepted by Liasse Fiscale is that of EBP.
So "l10n_fr_liasse_fiscale" or "l10n_fr_teledec" would be better names.

<button name="check_report" position="after">
or
<button name="check_report"
string="EBP csv File" type="object"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to "Liasse fiscale" or something as explicit.

@alexis-via
Copy link
Contributor

@clonedagain This module is absolutely not linked to teledec ; it works with all liasse fiscale software that accept EBP balance export file as input. It's just that we tested it successfully with Teledec... but it will work with other liasse fiscale software (I have a new customer that uses another liasse fiscale software and will certainly use this module)

@alexis-via
Copy link
Contributor

The PEP8 warnings are located in other modules.

@alexis-via
Copy link
Contributor

Let's move on for this PR 👍 I plan to port it to v8 after this merge.

@bguillot
Copy link

bguillot commented Jun 3, 2015

👍

Alexis de Lattre added 4 commits August 25, 2015 01:12
@alexis-via alexis-via force-pushed the 7.0-account-balance-ebp-csv-export branch from c2a1268 to 13c9d36 Compare August 24, 2015 23:19
@alexis-via
Copy link
Contributor

I rebased the PR and removed the changes that weren't related to the module account_balance_ebp_csv_export

@alexis-via
Copy link
Contributor

Travis is green at last ! Ready to merge now 👍

alexis-via pushed a commit that referenced this pull request Aug 25, 2015
@alexis-via alexis-via merged commit d96bcae into OCA:7.0 Aug 25, 2015
alexis-via pushed a commit to akretion/l10n-france that referenced this pull request Oct 9, 2015
…xport

7.0 account balance ebp csv export
alexis-via pushed a commit to akretion/l10n-france that referenced this pull request Oct 29, 2015
…xport

7.0 account balance ebp csv export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants