Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] l10n_de_steuernummer #48

Merged
merged 8 commits into from
May 22, 2019
Merged

[12.0][MIG] l10n_de_steuernummer #48

merged 8 commits into from
May 22, 2019

Conversation

tbaden
Copy link
Member

@tbaden tbaden commented May 20, 2019

No description provided.

@oca-clabot
Copy link

Hey @tbaden, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@tbaden
Copy link
Member Author

tbaden commented May 20, 2019 •
edited

@pedrobaeza whats the right readme file for known issues?
at the moment I added it into USAGE.rst like this:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Known Issues
======================
...

@tbaden tbaden mentioned this pull request May 20, 2019
Closed
5 tasks
@tbaden tbaden force-pushed the 12.0-mig-l10n_de_steuernummer branch from eac20d0 to a1c896f Compare May 20, 2019 12:26
@pedrobaeza pedrobaeza added this to the 12.0 milestone May 20, 2019
@tbaden tbaden force-pushed the 12.0-mig-l10n_de_steuernummer branch from a1c896f to af489aa Compare May 20, 2019 13:09
@tbaden tbaden force-pushed the 12.0-mig-l10n_de_steuernummer branch from af489aa to dec2c35 Compare May 20, 2019 13:22
chienandalu
chienandalu approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok (no runbot though) 👍 Thanks!

@tbaden
Copy link
Member Author

tbaden commented May 20, 2019

something I can do about it on my end @chienandalu ?

@chienandalu
Copy link
Member

Sure @pedrobaeza has the answer :)

@pedrobaeza
Copy link
Member

We are carrying problems in runbot infrastructure, but I'm afraid it's not in my hands. @gurneyalex is doing his best for solving it.

@ernestotejeda
Copy link
Member

In runbot it's possible to create a partner with VAT number DE123 and I don't think that is correct. When i try, locally, it doesn't happen the same, that is, locally is not possible to create a contact with that VAT number. I don't now why that happens
Captura de pantalla de 2019-05-21 17-54-26

@tbaden
Copy link
Member Author

tbaden commented May 22, 2019

@ernestotejeda my first guess would be the current runbot issues. The module works on my local maschine as well.

@chienandalu
Copy link
Member

@ernestotejeda I tried runbot with the partner you created and the validation error raises fine:
image

pedrobaeza
pedrobaeza approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that is working

@pedrobaeza pedrobaeza merged commit 2912717 into OCA:12.0 May 22, 2019
@tbaden tbaden deleted the 12.0-mig-l10n_de_steuernummer branch May 22, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@tbaden @oca-clabot @chienandalu @pedrobaeza @ernestotejeda @OCA-git-bot @antespi @oca-transbot @oca-travis @OSevangelist