Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n_it_ricevute_bancarie_report] aggiunto report sintetico totali scad... #28

Merged
merged 1 commit into from
May 16, 2016
Merged

Conversation

scigghia
Copy link
Contributor

...enze

@eLBati
Copy link
Member

eLBati commented Aug 7, 2014

LGTM 👍

@eLBati
Copy link
Member

eLBati commented Sep 12, 2014

About tests error: OCA/reporting-engine#1

@max3903
Copy link
Sponsor Member

max3903 commented Nov 7, 2014

Can you keep the module name (ricevute_bancarie) in english ?

@eLBati
Copy link
Member

eLBati commented Nov 9, 2014

@max3903 this is an extension of the existing (and not renameable for stable versions) l10n_it_ricevute_bancarie, so I would keep the current name, for coherence.

Note: l10n_it_ricevute_bancarie was named that way because we did not find a clear and generic translation for 'ricevute bancarie', as it identifies a specific italian banking procedure.

@max3903
Copy link
Sponsor Member

max3903 commented Feb 6, 2015

@scigghia Can you fix PEP8 errors ?

@scigghia
Copy link
Contributor Author

scigghia commented Feb 6, 2015

Sure!
Asap

@dcorio
Copy link
Contributor

dcorio commented Feb 6, 2015

@max3903 @eLBati i don't know the english translation of "ricevuta bancaria" (literally "bank receipt", that i wouldn't use) but in France there's a very similar procedure which is the lettre de change relevé.

eLBati added a commit to archetipo/l10n-italy that referenced this pull request Apr 1, 2015
@scigghia
Copy link
Contributor Author

@eLBati @dcorio what is missing here?

@eLBati
Copy link
Member

eLBati commented Feb 18, 2016

@scigghia it seems this #28 (comment)

@eLBati
Copy link
Member

eLBati commented Feb 18, 2016

But, as 6.1 branch is full of PEP8 errors and the lines of code modified by this PR do not introduce new errors, I think it can be merged as is
@max3903 what do you think?

@tafaRU
Copy link
Member

tafaRU commented Feb 18, 2016

I think it can be merged as is

I'm in favour too 👍

@paolovalier
Copy link

👍

@eLBati eLBati merged commit 546a6fa into OCA:6.1 May 16, 2016
OpenCode pushed a commit to OpenCode/l10n-italy that referenced this pull request May 9, 2017
…e_location

[IMP] picking_dispatch_wave: select only moves with internal source location (avoid to select dropshipping moves)
patrickt-oforce pushed a commit to patrickt-oforce/l10n-italy that referenced this pull request Mar 9, 2022
[FIX][l10n_it_statutory_financial_statements]
vincenzoterzulli pushed a commit to ElvenStudio/l10n-italy that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants