XmlAuditfileFinancieel syntax fix #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some leftover + from git merging was in the file which resulted in validation errors.
astirpe
approved these changes
Jan 31, 2018
astirpe
suggested changes
Feb 1, 2018
| @@ -148,7 +148,7 @@ | |||
| <docRef><t t-esc="l.ref" t-esc-options='{"widget": "auditfile.string999"}' /></docRef> | |||
| <effDate><t t-esc="l.date" /></effDate> | |||
| <desc><t t-esc="l.name" /></desc> | |||
| <amnt><t t-esc="l.credit or l.debit" /></amnt> | |||
| <amnt><t t-esc="round(l.credit or l.debit, 2)" /></amnt> | |||
There was a problem hiding this comment.
I think you don't need to round here. The risk is that the rounding will generate an amount different than l.balance. See #130 (comment)
There was a problem hiding this comment.
Well we had this error:
:507419:0:ERROR:SCHEMASV:SCHEMAV_CVC_FRACTIONDIGITS_VALID: Element '{http://www.auditfiles.nl/XAF/3.2}amnt': [facet 'fractionDigits'] The value '0.00999999999999' has more fractional digits than are allowed ('2').
There was a problem hiding this comment.
Isn't abs(l.balance) fixing that issue as well?
astirpe
approved these changes
Feb 1, 2018
|
please squash your commits to one about the country, one about the rounding |
hbrunn
approved these changes
Feb 1, 2018
Apply rounding fix as suggested by astirpe
|
There need to be 3 commits as they fix 3 different things: syntax error in xsd, JE country and rounding error. |
|
ah right, the -+ line fooled me. Will merge after green runbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some leftover + from git merging was in the file which resulted in
validation errors.