Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][ADD] l10n_nl_tax_statement_icp #151

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Feb 7, 2018

This module extends the l10n_nl_tax_statement module, providing a new statement for the Intra-Community transactions declaration (ICP declaration).

The new ICP declaration report is based on the tag 3b - Leveringen naar landen binnen de EU (omzet), the same as it is already configured for the BTW aangifte report (of module l10n_nl_tax_statement). The period is also the same as the one selected in the BTW aangifte report. This way the ICP report and the BTW aangifte report based on the same data, as discussed in #102.

To install this module, you need to be sure that version 11.0.2.0.0 (or later) of module l10n_nl_tax_statement is installed.

This module supersedes module l10n_nl_intrastat.

The discussion about the redesign/replacement of module l10n_nl_intrastat is here: #102

Fixes #102

@astirpe astirpe force-pushed the 11_add_l10n_nl_tax_statement_icp branch 2 times, most recently from 2ac9081 to bcc0720 Compare February 8, 2018 18:13
@hbrunn hbrunn added this to the 11.0 milestone Mar 6, 2018
@astirpe astirpe mentioned this pull request Jun 12, 2018
9 tasks
@astirpe astirpe force-pushed the 11_add_l10n_nl_tax_statement_icp branch 7 times, most recently from 58b0ba3 to dbb9769 Compare September 10, 2018 12:01
Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested at customers and it takes the correct amount now.

@astirpe
Copy link
Member Author

astirpe commented Dec 4, 2018

I think this PR is good enough for being reviewed.

Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report works fine now

@astirpe
Copy link
Member Author

astirpe commented Jan 14, 2019

Thanks for the approval!
Please also approve #214 in order to speed up the fixing of the travis error (otherwise this PR cannot be merged).

@hbrunn
Copy link
Member

hbrunn commented Jan 14, 2019

@astirpe do you want to squash some commits before merging?

@astirpe astirpe force-pushed the 11_add_l10n_nl_tax_statement_icp branch from 9db0a71 to 1184be2 Compare January 15, 2019 07:32
@astirpe
Copy link
Member Author

astirpe commented Jan 15, 2019

Squashed. Thanks!

@hbrunn hbrunn merged commit e3e63eb into OCA:11.0 Jan 15, 2019
@astirpe astirpe deleted the 11_add_l10n_nl_tax_statement_icp branch January 15, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants