Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][IMP] l10n_nl_tax_statement: display detailed move lines #212

Merged
merged 1 commit into from
Jan 28, 2019
Merged

[11.0][IMP] l10n_nl_tax_statement: display detailed move lines #212

merged 1 commit into from
Jan 28, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Dec 3, 2018

With this PR:

  • Added buttons in statement lines to view the related move lines in details
  • Added tests

@astirpe astirpe force-pushed the 11_imp_l10n_nl_tax_statement branch from ea382aa to 15c283b Compare December 3, 2018 11:43
yung-wang
yung-wang reviewed Dec 3, 2018
View reviewed changes
Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, can you also add the drill down to 5b?

yung-wang
yung-wang approved these changes Dec 3, 2018
View reviewed changes
Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine here

@hbrunn hbrunn added this to the 11.0 milestone Jan 9, 2019
@hbrunn
Copy link
Member

hbrunn commented Jan 28, 2019

@astirpe do you want to squash commits?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@astirpe astirpe force-pushed the 11_imp_l10n_nl_tax_statement branch from 4bcf5db to 0e9fe90 Compare January 28, 2019 12:30
@astirpe
Copy link
Member Author

astirpe commented Jan 28, 2019

Squashed. Thanks!

@hbrunn hbrunn merged commit 54bcf0c into OCA:11.0 Jan 28, 2019
@astirpe astirpe deleted the 11_imp_l10n_nl_tax_statement branch January 28, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

@yung-wang yung-wang yung-wang approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astirpe @hbrunn @OCA-git-bot @yung-wang