Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][ADD] l10n_nl_account_credit_control: Dutch localization for credit control #213

Merged
merged 2 commits into from
Jan 31, 2019
Merged

[11.0][ADD] l10n_nl_account_credit_control: Dutch localization for credit control #213

merged 2 commits into from
Jan 31, 2019

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Dec 13, 2018

This module calculates the dunning fee based on the method defined by the WIK:
https://www.rijksoverheid.nl/onderwerpen/hulp-bij-schulden/vraag-en-antwoord/hoogte-incassokosten.

@astirpe
Copy link
Member

astirpe commented Dec 14, 2018

Some tests of the KvK module are failing now, because the KvK API service changed their response data recently.
I could create a PR for removing the failing assert lines, since they are not decisive for making the tests valid.
I will do it as soon as I have time. Or, If you prefer to speed up your PR, you could do it yourself within this PR, in this case I will approve it quickly.

@astirpe astirpe mentioned this pull request Dec 14, 2018
Merged
@tarteo
Copy link
Member Author

tarteo commented Dec 18, 2018

@astirpe I fixed the tests.

astirpe
astirpe approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarteo
[ADD] l10n_nl_account_credit_control
3c5aaff 
[ADD] OCA dependency

[FIX] Lint and kvk tests

[FIX] Tests

[IMP] Identation
@hbrunn hbrunn added this to the 11.0 milestone Jan 9, 2019
hbrunn
hbrunn reviewed Jan 28, 2019
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

l10n_nl_account_credit_control/__manifest__.py
'version': '11.0.1.0.0',
'development_status': 'Beta',
'depends': [
'account_credit_control',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you deliberately don't use https://github.com/OCA/account-financial-tools/tree/11.0/account_credit_control_dunning_fees ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still please rebase, then I can merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...I'm oldfashioned. Just tried out the github editor, seems to work

Copy link
Member Author

@tarteo tarteo Jan 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was already trying to do it, but you already solved it thanks 😄.

@hbrunn hbrunn merged commit a2b40e4 into OCA:11.0 Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn left review comments

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tarteo @astirpe @hbrunn