Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] l10n_nl_location_nuts #234

Merged
merged 7 commits into from Jul 28, 2020
Merged

[12.0][MIG] l10n_nl_location_nuts #234

merged 7 commits into from Jul 28, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented May 24, 2019

No description provided.

tbaden
tbaden suggested changes May 24, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: just one thing about the test change.

l10n_nl_tax_statement/tests/test_l10n_nl_vat_statement.py Outdated Show resolved Hide resolved
@astirpe astirpe mentioned this pull request Nov 6, 2019
Merged
1 task
@astirpe astirpe force-pushed the 12_mig_l10n_nl_location_nuts branch from 6523772 to 031544e Compare December 2, 2019 09:54
@astirpe
Copy link
Member Author

astirpe commented Dec 2, 2019

@tbaden I rebased the branch since the tests were fixed in the main repository. Could you update your review?

@hbrunn
Copy link
Member

hbrunn commented Jul 28, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-234-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 84abe27 into OCA:12.0 Jul 28, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28afece. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_mig_l10n_nl_location_nuts branch July 28, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden requested changes

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astirpe @hbrunn @OCA-git-bot @tbaden @oca-travis