Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13.0 mig l10n nl bank #240

Merged
merged 8 commits into from
Feb 13, 2020
Merged

13.0 mig l10n nl bank #240

merged 8 commits into from
Feb 13, 2020

Conversation

lfreeke
Copy link
Contributor

@lfreeke lfreeke commented Sep 30, 2019

No description provided.

astirpe
astirpe approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Runbot: OK. Code review: OK.

@lfreeke lfreeke mentioned this pull request Sep 30, 2019
Closed
6 tasks
StephanRozendaal
StephanRozendaal approved these changes Oct 11, 2019
View reviewed changes
Copy link

@StephanRozendaal StephanRozendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Oct 29, 2019

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-240-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 29, 2019
@OCA-git-bot
Merge PR #240 into 13.0
909cd55 
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-240-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member

hbrunn commented Nov 19, 2019

/ocabot merge

OCA-git-bot added a commit that referenced this pull request Nov 19, 2019
@OCA-git-bot
Merge PR #240 into 13.0
23e021b 
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-240-by-hbrunn-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-240-by-hbrunn-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member

hbrunn commented Nov 19, 2019

@lfreeke please fix the linting the oca bot complains about

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ploegvde and others added 7 commits February 13, 2020 13:59
@lfreeke lfreeke force-pushed the 13.0-mig-l10n_nl_bank branch 2 times, most recently from 21db752 to 2b74021 Compare February 13, 2020 13:18
@lfreeke
Copy link
Contributor Author

lfreeke commented Feb 13, 2020

@hbrunn branch should be mergable

hbrunn
hbrunn approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge, if you want to add yourself as contributor you can do so in another PR

@hbrunn
Copy link
Member

hbrunn commented Feb 13, 2020

/ocabot merge
(or be fast enough before ocabot kicks in)

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-240-by-hbrunn-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 13, 2020
@OCA-git-bot
Merge PR #240 into 13.0
b9b4c7e 
Signed-off-by hbrunn
@OCA-git-bot OCA-git-bot merged commit 97e5fa5 into OCA:13.0 Feb 13, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2711a44. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanRozendaal StephanRozendaal StephanRozendaal approved these changes

@hbrunn hbrunn hbrunn approved these changes

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lfreeke @OCA-git-bot @hbrunn @StephanRozendaal @astirpe @ploegvde @oca-travis