Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] l10n_nl_postcode #241

Merged
merged 7 commits into from
Jul 29, 2020
Merged

[13.0][MIG] l10n_nl_postcode #241

merged 7 commits into from
Jul 29, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Sep 30, 2019

No description provided.

StephanRozendaal
StephanRozendaal suggested changes Oct 11, 2019
View reviewed changes
Copy link

@StephanRozendaal StephanRozendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the references in URLs in the README and index.html files related to the Odoo version, most still point to 12.0.

@astirpe
Copy link
Member Author

astirpe commented Oct 11, 2019

@StephanRozendaal the README and the index.html file are automatically updated by the bot after the merge. I just updated the README manually. The bot will update the index.html file.

StephanRozendaal
StephanRozendaal approved these changes Oct 11, 2019
View reviewed changes
Copy link

@StephanRozendaal StephanRozendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hbrunn
Copy link
Member

hbrunn commented Jul 28, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-241-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 28, 2020
@OCA-git-bot
Merge PR #241 into 13.0
82bdafa 
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-241-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Jul 29, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-241-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 29, 2020
@OCA-git-bot
Merge PR #241 into 13.0
79a8ce2 
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-241-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9b6cca3 into OCA:13.0 Jul 29, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 801bc8f. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 13_mig_l10n_nl_postcode branch July 29, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanRozendaal StephanRozendaal StephanRozendaal approved these changes

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astirpe @hbrunn @OCA-git-bot @StephanRozendaal