Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] l10n_nl_xaf_auditfile_export: avoid character / in filename #250

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[12.0][FIX] l10n_nl_xaf_auditfile_export: avoid character / in filename #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions l10n_nl_xaf_auditfile_export/models/xaf_auditfile_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def button_generate(self):
'xmlns="http://www.auditfiles.nl/XAF/3.2">', 1)

filename = self.name + '.xaf'
filename = filename.replace(os.sep, ' ')
tmpdir = mkdtemp()
auditfile = os.path.join(tmpdir, filename)
archivedir = mkdtemp()
Expand Down
8 changes: 8 additions & 0 deletions l10n_nl_xaf_auditfile_export/tests/test_l10n_nl_xaf_auditfile_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import base64
from io import BytesIO
import os
from zipfile import ZipFile

from odoo.tests.common import TransactionCase
Expand Down Expand Up @@ -89,3 +90,10 @@ def test_04_export_success_unit4(self):
filelist = archive.filelist
contents = archive.read(filelist[-1]).decode()
self.assertTrue(contents.startswith('<?xml '))

def test_05_export_success(self):
''' Export auditfile with / character in filename '''
record = self.env['xaf.auditfile.export'].create({})
record.name += '%s01' % os.sep
record.button_generate()
self.assertTrue(record)