Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] l10n_nl_xaf_auditfile_export #253

Merged
merged 58 commits into from Mar 20, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jan 17, 2020

Includes #247
Includes #250
Includes #255

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StefanRijnhart StefanRijnhart added this to the 13.0 milestone Feb 14, 2020
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional review

hbrunn and others added 24 commits March 19, 2020 11:41
and don't output empty fields for enums
* Align code with l10n_nl_xaf_auditfile_export V8

* Porting to V10

* Update readme

* Minor code review

* Fix start and end date of periods + updated readme

* Fix condition when checking dates

* Update Usage in readme according V10 menu names

* Replace bank field with bank_id

* Make menuitem compatible with Odoo enterprise

* Add nl.po file (courtesy of @ploegvde)

* Fix menu name in readme

* Add empty line in chatter between errors
@astirpe astirpe force-pushed the 13_mig_l10n_nl_xaf_auditfile_export branch from 7c35f99 to 9f7ca9b Compare March 19, 2020 10:53
@StefanRijnhart
Copy link
Member

Can you check travis?
2020-03-19 11:05:51,666 5744 ERROR openerp_test odoo.addons.l10n_nl_xaf_auditfile_export.models.xaf_auditfile_export: Element '{http://www.auditfiles.nl/XAF/3.2}fiscalYear': [facet 'maxLength'] The value has a length of '42'; this exceeds the allowed maximum length of '9'. (<string>, line 0)

@astirpe astirpe force-pushed the 13_mig_l10n_nl_xaf_auditfile_export branch from 9f7ca9b to 52e0753 Compare March 20, 2020 08:18
@astirpe
Copy link
Member Author

astirpe commented Mar 20, 2020

@StefanRijnhart All green!

@StefanRijnhart
Copy link
Member

Perfect!
/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-253-by-StefanRijnhart-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 52f66f1 into OCA:13.0 Mar 20, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 640ef5f. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 13_mig_l10n_nl_xaf_auditfile_export branch March 20, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet