New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] l10n_nl_xaf_auditfile_export #253
[13.0][MIG] l10n_nl_xaf_auditfile_export #253
Conversation
d9e6b99
to
f1ce05f
Compare
6fd8dd2
to
7c35f99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, functional review
and don't output empty fields for enums
via custom widgets
* Align code with l10n_nl_xaf_auditfile_export V8 * Porting to V10 * Update readme * Minor code review * Fix start and end date of periods + updated readme * Fix condition when checking dates * Update Usage in readme according V10 menu names * Replace bank field with bank_id * Make menuitem compatible with Odoo enterprise * Add nl.po file (courtesy of @ploegvde) * Fix menu name in readme * Add empty line in chatter between errors
Generating and storing a 70MB auditfile takes 8 minutes for qweb, but for lxml.etree to reconstruct using a namespace takes 3 hours and 1GB of extra memory. Further optimization is achieved by sticking to the Odoo prefetch size when chunking record sets. As XML compresses very well, the auditfile is now stored in the Odoo database in compressed format for easier handling and saving disk space.
7c35f99
to
9f7ca9b
Compare
Can you check travis? |
9f7ca9b
to
52e0753
Compare
@StefanRijnhart All green! |
Perfect! |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 640ef5f. Thanks a lot for contributing to OCA. ❤️ |
Includes #247
Includes #250
Includes #255