[FIX] Use right encoding when generating XML File #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 apparently, the XML specs say any application should support a lower case encoding (not: must) so this seems appropriate |
|
👍 |
|
@RoelAdriaans-B-informed could you rebase on 8.0? then travis should become green |
File should have UTF-8 as encoding, not utf8.
hbrunn
added a commit
that referenced
this pull request
Mar 1, 2016
…issue [FIX] Use right encoding when generating XML File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File should have UTF-8 as encoding, not utf8.
We had errors with reading the generated XAF file with the old encoding, solved it by changing the encoding to UTF-8. This is used in python too.