Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Porting l10n_nl_bsn to V9 #42

Merged
merged 3 commits into from
Apr 2, 2016
Merged

[ADD] Porting l10n_nl_bsn to V9 #42

merged 3 commits into from
Apr 2, 2016

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 10, 2016

No description provided.

@hbrunn hbrunn added this to the 9.0 milestone Mar 10, 2016
@hbrunn
Copy link
Member

hbrunn commented Mar 10, 2016

👍

1 similar comment
@max3903
Copy link
Sponsor Member

max3903 commented Mar 10, 2016

👍

@RoelAdriaans
Copy link

Does this port have the same issue as #41?
If so, maybe wait before merging until that error is fixed.

@astirpe
Copy link
Member Author

astirpe commented Mar 11, 2016

Yes, the same issue #41 occurs on this port.
It's a very minor issue. It would probably never occur to an end user because, to reproduce it, you have to:

  1. write a correct BSN and save
  2. write a wrong BSN without saving
  3. write the same BSN as point 1.

Is it a blocking issue for you?

@StefanRijnhart
Copy link
Member

👍

@hbrunn hbrunn merged commit 5de37a4 into OCA:9.0 Apr 2, 2016
@astirpe astirpe deleted the 90_porting_l10n_nl_bsn branch April 2, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astirpe @hbrunn @max3903 @RoelAdriaans @StefanRijnhart