Improve search for another partner with same BSN #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # refine search in case of multicompany setting | ||
| if partner.company_id: | ||
| args += [('company_id', '=', partner.company_id.id)] | ||
| partners = self.search(args, limit=1) | ||
| other_partner = self.search(args, limit=1) | ||
| # is another partner exists, display a warning |
|
👍 (code review only) |
|
can't you search for the partner's id in the case it's available? |
|
@hbrunn I've chosen this solution for 2 reasons, one is technical and the other is functional. Technical: searching in an onchange method, I cannot read my current record id, because self.id is always NewId. This occurs also in case the record was already stored in the database. Functional: let's say, for any reason, you have some duplicated partners (individuals with the same name) and you want to keep them as they are. In this case, there is no reason to raise a warning, saying that another person has the same BSN. In facts, the same duplicated partners should get the same BSN. |
|
@astirpe thanks, makes sense. 👍 |
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41