Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Port l10n_nl_postcodeapi to V10 #54

Merged
merged 4 commits into from
Nov 8, 2016
Merged

[MIG] Port l10n_nl_postcodeapi to V10 #54

merged 4 commits into from
Nov 8, 2016

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 14, 2016

Seems working fine to me.
I'm porting module partner_street_number as well.

@astirpe
Copy link
Member Author

astirpe commented Oct 14, 2016

Porting of partner_street_number: OCA/partner-contact#314

@hbrunn hbrunn added this to the 10.0 milestone Oct 15, 2016
@hbrunn
Copy link
Member

hbrunn commented Nov 1, 2016

@astirpe tests fail

@astirpe
Copy link
Member Author

astirpe commented Nov 1, 2016

Waiting for OCA/partner-contact#314 being merged.

@@ -1 +1 @@
partner-contact https://github.com/OCA/partner-contact 8.0
partner-contact https://github.com/OCA/partner-contact 10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better leave out the url and the branch name altogether, then the maintainer tools will pick the current version's branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@astirpe astirpe mentioned this pull request Nov 3, 2016
3 tasks
@hbrunn
Copy link
Member

hbrunn commented Nov 7, 2016

restarted runbot after OCA/partner-contact#314 was merged

Copy link
Member

@pankk pankk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hbrunn hbrunn merged commit 8d213a5 into OCA:10.0 Nov 8, 2016
@astirpe astirpe deleted the 10_port_l10n_nl_postcodeapi branch November 8, 2016 19:32
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Jun 11, 2018
hbrunn pushed a commit that referenced this pull request Sep 5, 2018
janverb pushed a commit to janverb/l10n-netherlands that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants