-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] l10n_nl_normalize_zip #56
Conversation
@pedrobaeza can you add server-tools to runbot? |
@hbrunn with this module you format the zip for every partner regardless if it's country is Netherlands or not. Is it correct? In this case is it possible to format the zip depending on the Country if it's already set? |
server-tools added in runbot and rebuild launched |
@pedrobaeza thanks! Judging from https://en.wikipedia.org/wiki/List_of_postal_codes, the Dutch format is unique, so it shouldn't clash with some other country and we avoid reading the partners for every write on the zip code. |
👍 LGTM |
👍 |
@hbrunn when installing the module, the zip value of existing partners is not automatically updated; was it intentional to not provide a post_init_hook for normalizing the zip for all the existing partners? Code review is 👍 for me |
intentional as in not relevant for my current problem. It's certainly a good thing to have for people who want to install this in an existing database, should be very straightforward to add |
can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Normalize Dutch zip codes
This module was written to have zipcodes formatted in the standard Dutch way, which is 0000 XX.
Usage
To use this module, you need to:
#. fill in a zip number on a partner
#. be happy that whatever you fill in there, if it looks remotely like a Dutch zip code, it will be forced to the format above.