Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serbia to the list of countries #60

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Conversation

thomaspaulb
Copy link
Contributor

No description provided.

@hbrunn hbrunn added this to the 8.0 milestone Mar 2, 2017
@hbrunn
Copy link
Member

hbrunn commented Mar 2, 2017

this looks like a no-brainer, but I'm a bit concerned that this might break at the receiving end. If the importing application does validation against the official xsd (http://www.softwarepakket.nl/swpakketten/auditfiles/auditfile_financieel.php?bronw=1 to my knowledge), files containing serbia won't work. Did you submit files containing this to the tax office and can they use it?

@astirpe
Copy link
Member

astirpe commented Mar 2, 2017

@hbrunn even if the tax office can use it, the point is that the spec file XmlAuditfileFinancieel3.2.xsd will be different than the "certified" one. This is not a technical issue, it's more a specification issue. I would like to help, but how?

@hbrunn
Copy link
Member

hbrunn commented Mar 2, 2017

file a PR against the tax office's github repo? ducks and runs

seriously, I have no idea how to approach this on a technical level. Serbia is Serbia, so you can't use some existing code. And you also can't map stuff to a different country. But this can't be the first time somebody encountered this. Shouldn't there be someone at the tax office to ask?

But taking a step back: Serbia is not (yet) a member of the European Union, are you sure @thomaspaulb that you actually need to declare trade with Serbia? No intrastat document I can find says something about Serbia...

@thomaspaulb
Copy link
Contributor Author

thomaspaulb commented Mar 2, 2017 via email

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the XAF specs on this point are derived from ISO3166, and RS is included in ISO3166, I think in this case it is fine to fix the XAF specs.

Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currency CSD (Serbian dinar) is already contained in the XAF specs, so I'm definitely convinced that Serbia must be added to the list of countries :)

@hbrunn
Copy link
Member

hbrunn commented Jun 4, 2017

I'll go with the majority here, even though I consider this dangerous because a file with this country simply is invalid according to the only official XSD I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants