[10.0][MIG] Port l10n_nl_tax_declaration_reporting #63
Conversation
astirpe
force-pushed
the
10_port_l10n_nl_tax_declaration_reporting
branch
from
6388400
to
d94324b
Compare
|
Rebased PR, in order to apply the latest updates made on |
| JOIN account_invoice_line inv_line | ||
| on inv_line.id = inv_line_tax.invoice_line_id | ||
| JOIN account_invoice inv | ||
| on inv.id = inv_line.invoice_id |
There was a problem hiding this comment.
AND inv.id = inv_tax.invoice_id
There was a problem hiding this comment.
in my version for 9, I changed the query entirely, because the way the query stands here, it will return the amounts multiplied by the amount of lines which have the same tax (note that inv_tax.amount is the sum of all lines with the tax in the invoice, not just the amount of some specific line): #68 (comment)
|
I see that the current version of the report does not include taxes posted directly on move lines. Is that the WIP-part? |
|
@StefanRijnhart As far as I know, the VAT reporting should be only calculated based on invoices. But since I'm not accountant I'm going to ask to some financial consultant :) Thank you for the tip on the query, I will update it ASAP! And yes, I consider this PR still in an early WIP stage... |
|
That assumption is just wrong. But I think I would prefer a different approach altogether. Maybe this module could be refactored to reformat the results of https://github.com/OCA/account-financial-reporting/tree/10.0/account_tax_balance? |
|
@StefanRijnhart Indeed it would be a better approach! Thank you for mentioning that module, I will work on this PR tomorrow... |
|
@astirpe that would be great! You might want to check this PR of mine to fix the reporting of taxes on bank transactions in this module OCA/account-financial-reporting#284 |
|
If the Community agrees, this PR is superseded by #70 |
Porting module
l10n_nl_tax_declaration_reportingto V10.This is a work in progress...