Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module for import BRD MT940bank statements. #10

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Add module for import BRD MT940bank statements. #10

merged 4 commits into from
Oct 20, 2017

Conversation

feketemihai
Copy link
Member

No description provided.

@feketemihai feketemihai added this to the 8.0 milestone Jun 21, 2016
pedrobaeza
pedrobaeza reviewed Jun 21, 2016
View reviewed changes
account_bank_statement_import_mt940_ro_brd/README.rst
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License: AGPL-3

Import MT940 ROMANIAN BRD Bank Statements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a line above

@pedrobaeza
Copy link
Member

You should called the module l10n_ro_account_bank_statement_import_mt940_brd

@feketemihai feketemihai mentioned this pull request Jun 22, 2016
Merged
@feketemihai
Copy link
Member Author

feketemihai commented Oct 21, 2016 •
edited
Loading

@pedrobaeza Can i have your last review here, please...

pedrobaeza
pedrobaeza requested changes Oct 21, 2016
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make at least basic assert like the number of lines read, and some comparison between hardcoded amounts versus read amounts.

@feketemihai
Copy link
Member Author

@pedrobaeza Updated test, thanks a lot for reviewing in short time. Thanks again.

@feketemihai feketemihai merged commit 4dd8815 into OCA:8.0 Oct 20, 2017
@feketemihai feketemihai deleted the brd_statement_import branch March 7, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feketemihai @pedrobaeza