Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romania - Vat on payment #9

Merged
merged 8 commits into from
Jun 22, 2016
Merged

Conversation

feketemihai
Copy link
Member

Add module to support Romanian Vat on payment legal and check for partners on Fiscal Administration for VAT on Payment.

@feketemihai feketemihai added this to the 8.0 milestone Mar 8, 2016
@@ -57,3 +57,6 @@ docs/_build/

# OSX Files
*.DS_Store

# ANAF Data
l10n_ro_vat_on_payment/data/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks if the module repo is not writeable by the Odoo user. How about using something like {tools.config['data_dir']}/l10n_ro_vat_on_payment/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanRijnhart Can we add odoo parameter in .gitignore, i don't know if we can do it...i will update the path where the files from Fiscal Authorities will be downloaded in the tools.config['data_dir'], and remove the .gitignore...

@StefanRijnhart
Copy link
Member

Thanks for updating the path! Not sure what you mean with 'Can we add odoo parameter in .gitignore' though.

@feketemihai
Copy link
Member Author

@StefanRijnhart I mean about the data_dir which is in the config of Odoo...can we add like you said in upper side, {tools.config['data_dir']}...

@StefanRijnhart
Copy link
Member

The data_dir is, on Linux, in ~/.local/Share/Odoo, which is outside the git repo so it does not have to be ignored. Is that what you mean?

@feketemihai
Copy link
Member Author

This is ok, my issue was about gitignore and if we can specify the path as a variable(paramater) taken from odoo (or python) tools...i didn't know it was possible...

@StefanRijnhart
Copy link
Member

👍 then.

@StefanRijnhart
Copy link
Member

Merging because of understaffed project.

@StefanRijnhart StefanRijnhart merged commit de1346e into OCA:8.0 Jun 22, 2016
@feketemihai
Copy link
Member Author

@StefanRijnhart Thanks for review and merge. Can i have your review when you have time on #10 , please.

@feketemihai feketemihai deleted the vat_on_payment branch June 27, 2016 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants