-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Romania - Vat on payment #9
Conversation
@@ -57,3 +57,6 @@ docs/_build/ | |||
|
|||
# OSX Files | |||
*.DS_Store | |||
|
|||
# ANAF Data | |||
l10n_ro_vat_on_payment/data/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks if the module repo is not writeable by the Odoo user. How about using something like {tools.config['data_dir']}/l10n_ro_vat_on_payment/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanRijnhart Can we add odoo parameter in .gitignore, i don't know if we can do it...i will update the path where the files from Fiscal Authorities will be downloaded in the tools.config['data_dir'], and remove the .gitignore...
…nore, update with 8.0 branch.
Thanks for updating the path! Not sure what you mean with 'Can we add odoo parameter in .gitignore' though. |
@StefanRijnhart I mean about the data_dir which is in the config of Odoo...can we add like you said in upper side, {tools.config['data_dir']}... |
The data_dir is, on Linux, in ~/.local/Share/Odoo, which is outside the git repo so it does not have to be ignored. Is that what you mean? |
This is ok, my issue was about gitignore and if we can specify the path as a variable(paramater) taken from odoo (or python) tools...i didn't know it was possible... |
👍 then. |
Merging because of understaffed project. |
@StefanRijnhart Thanks for review and merge. Can i have your review when you have time on #10 , please. |
Add module to support Romanian Vat on payment legal and check for partners on Fiscal Administration for VAT on Payment.