Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] l10n_es_mis_report #1284

Merged
merged 16 commits into from Mar 19, 2020
Merged

[13.0][MIG] l10n_es_mis_report #1284

merged 16 commits into from Mar 19, 2020

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Feb 13, 2020 •
edited

Standard migration.

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Feb 13, 2020
Closed
35 tasks
@HaraldPanten
Copy link
Contributor

Hola @MiquelRForgeFlow ,

Ya se ha hecho el merge del PR OCA/mis-builder#252 . Puedes revisar los fallos?

Una vez esté, te reviso funcionalmente.

Gracias!

JordiBForgeFlow and others added 14 commits March 16, 2020 15:04
@JordiBForgeFlow @MiquelRForgeFlow
[ADD] l10n_es_mis_reports: MIS reports for PL / BS
8b3af83
@JordiBForgeFlow @MiquelRForgeFlow
l10n_es_mis_report - compatibilizar con modalidad de no-expansión
c07b518 
de cuentas de mis_builder.
@JordiBForgeFlow @MiquelRForgeFlow
Corrige algunos conceptos del balance llevando
b1951d7 
ciertas cuentas al pasivo o activo según el signo
del saldo en lugar de llevar todo el debe y todo el haber.
@pedrobaeza @MiquelRForgeFlow
[IMP] l10n_es_mis_report: Use pbale/nbale
581e4b0 
For the balance sections where the sum of debtor/creditor balances is needed,
with this new expression we can get the interpreted result.
@JordiBForgeFlow @MiquelRForgeFlow
l10n_es_mis_report. Nunca autoexpandir la sección VII. Resultado del …
e3dbd26 
…ejercicio
@JordiBForgeFlow @MiquelRForgeFlow
remove es40000
184c1f8
@oca-travis @MiquelRForgeFlow
[UPD] Update l10n_es_mis_report.pot
520a1b4
@pedrobaeza @MiquelRForgeFlow
[IMP] l10n_es_mis_report: Add 473 to abbreviated balance
0c64c2a 
According discussion in OCA#970, adding the account to the template.
@pedrobaeza @MiquelRForgeFlow
[MIG] l10n_es_mis_report: Migration to 12.0
a6dece6 
* Standard procedure
* README by fragments
@oca-travis @MiquelRForgeFlow
[UPD] Update l10n_es_mis_report.pot
ceaefc8
@OCA-git-bot @MiquelRForgeFlow
[ADD] icon.png
f54669b
@antoniocanovas @MiquelRForgeFlow
[IMP] l10n_es_mis_report: Añadidos informes MIS para entidades SFL (O…
36d946e 
…CA#1074)
@oca-travis @MiquelRForgeFlow
[UPD] Update l10n_es_mis_report.pot
7030407
@OCA-git-bot @MiquelRForgeFlow
[UPD] README.rst
86e5eca
@MiquelRForgeFlow
Copy link
Contributor Author

Gracias @HaraldPanten , haces un trabajo fantástico revisando. Está listo para revisar! :)

HaraldPanten
HaraldPanten approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por mí está bien.

He probado distintos casos de uso con facturas, nóminas, asientos manuales... y veo que lo coge bien. He probado los informes básicos y todo me cuadra.

Gracias ti @MiquelRForgeFlow !

ValentinVinagre
ValentinVinagre approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM standard migration 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1284-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 2c2fe08 into OCA:13.0 Mar 19, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8af684d. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-mig-l10n_es_mis_report branch March 19, 2020 16:57
pedrobaeza pushed a commit to sygel-technology/l10n-spain that referenced this pull request Oct 23, 2020
@OCA-git-bot
Merge PR OCA#1284 into 13.0
c98c17b 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MiquelRForgeFlow @HaraldPanten @pedrobaeza @OCA-git-bot @ValentinVinagre @JordiBForgeFlow @oca-travis @antoniocanovas