-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][12.0][l10n_es_facturae]Error validating bank account #2488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En 13 y 14 se resolvió de la siguiente forma:
Puedes aplicar el mismo concepto? De hecho, puedes probar de hacer un cherry-pick
@@ -99,10 +99,8 @@ def _check_facturae_date(self): | |||
'FacturaE start and end dates are both required if one of ' | |||
'them is filled' | |||
)) | |||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Este cambio no es necesario para lo que estás haciendo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola Eric:
Es que me da errores pre-commit al pasarlo por el salto en los operadores lógicos. Si hay que hacer los mínimos cambios lo dejo como estaba y solo las modificaciones.
Ahora reviso la nota anterior y lo hago tal cual para que sea coherente con las otras versiones.
Puedes unirlo todo en un simple commit por favor? |
¿Tengo que hacer uno nuevo o hay algun modo de fusionarlos aqui? |
Lo puedes hacer aquí haciendo git commit rebase origin/12.0 Haz fixup de todos excepto del primero y acabalo haciendo git push --force |
0594556
to
d91ad5f
Compare
Hola etobella: ¿Porque se ha cerrado el MR? Es para entender el problema y arreglarlo. |
Github lo hizo al hacer tu un commit por lo que veo |
The bank account should not be mandatory except for facturae payment methods with code 2 and 4.
If it is true that other remaining payment methods it is interesting to be able to check that the bank account is added and that it is verified.
These changes are proposed to improve the functionality.