Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] l10n_es_intrastat_report - replace _note logic with notedict one #2711

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[13.0][IMP] l10n_es_intrastat_report - replace _note logic with notedict one #2711

merged 1 commit into from
Aug 16, 2023

Conversation

jdidderen-noviat
Copy link

@jdidderen-noviat jdidderen-noviat commented Dec 27, 2022 •
edited
Loading

Like discussed in PR OCA/intrastat-extrastat#206 and the work done in the PR OCA/intrastat-extrastat#179 , the _note logic was removed to use the one from the v14 with notedict.

All the explanations are given in the first PR mentionned (OCA/intrastat-extrastat#206)

The same work is done for France (OCA/l10n-france#401) and Belgium

@jdidderen-noviat jdidderen-noviat mentioned this pull request Dec 27, 2022
Closed
@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 28, 2022
victoralmau
victoralmau suggested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it is a necessary change.

Can you check tests to make all the necessary changes?

@jdidderen-noviat
Copy link
Author

@victoralmau As soon as the PR OCA/intrastat-extrastat#206 will be merged, I think the pipeline here will be fine.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 28, 2023
@pedrobaeza
Copy link
Member

Can you rebase and check CI status?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 4, 2023
This was referenced Jun 21, 2023
Closed
Merged
@pedrobaeza pedrobaeza force-pushed the 13.0-intrastat_product_notedict branch from 48f5262 to adae841 Compare August 16, 2023 18:03
@pedrobaeza
Copy link
Member

Merging for having the compatibility with the upstream change:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-2711-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f4bdea7 into OCA:13.0 Aug 16, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52106b0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau requested changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdidderen-noviat @pedrobaeza @OCA-git-bot @victoralmau