[13.0][IMP] intrastat_product - add notedict to some methods

[jdidderen-noviat]

See old PR #206 for the discussions around these changes.

PRs in the localization repositories :

• [13.0][IMP] l10n_es_intrastat_report - replace _note logic with notedict one l10n-spain#2711
• [13.0][IMP] l10n_fr_intrastat_product - replace _note logic with notedict one l10n-france#465

[jdidderen-noviat]

@pedrobaeza @luc-demeyer @alexis-via The PR was recreated since the old one #206 went stale. I did the same for the PR in the french localization.

[victoralmau]

IMO this is ready to be merged.

[pedrobaeza]

Please fw-port it to upper versions:

/ocabot merge patch

I'll merge the subsequent PRs as soon as this one gets merged.

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-221-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 8eb01ac. Thanks a lot for contributing to OCA. ❤️

[GuillemCForgeFlow]

Hi @pedrobaeza this change caused issues on one of our installations due to adding new arguments in the methods. Is this a common practice in the OCA?

[pedrobaeza]

No, it's not, but it wasn't the less bad option due to the incorrect previous situation after Brexit code. See this thread and the source one #206 for details (you should do it before writing, as it's all linked), and all the OCA modules were patched with the new arguments thanks to @jdidderen-noviat diligence. Only custom things outside OCA should be affected, and it's very easy to fix and detect (no silent problems, but direct crash).