Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] module l10n_ch_delivery_carrier_label_quickpac #613

Closed
wants to merge 8 commits into from

Conversation

StephaneMangin
Copy link
Contributor

@StephaneMangin StephaneMangin commented Sep 6, 2021

Previous PR : OCA/delivery-carrier#413
This carrier only delivers to Switzerland.

This is a new implementation for delivery carrier interaction with Quickpac.

This module has been based on oca/delivery-carrier/delivery_carrier_label_postlogistics. It uses an external python library that implements the Quickpac API through its OpenAPI generated client (Swagger Codegen, see: https://pypi.org/project/quickpac/)

<?xml version="1.0" encoding="utf-8"?>
<odoo noupdate="1">
<record id="product_quickpac_service" model="product.product">
<field name="image" type="base64" file="delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="image" type="base64" file="delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/>
<field name="image" type="base64" file="l10n_ch_delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same fix to be applied in all places where the logo is referenced

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done. Travis is restarted ^^

@StephaneMangin StephaneMangin marked this pull request as ready for review September 7, 2021 09:25
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yvaucher
Copy link
Member

Question, why putting it here instead of delivery-carrier repository where the postlogistics module is (which is also only for Switzerland)

@StephaneMangin
Copy link
Contributor Author

Question, why putting it here instead of delivery-carrier repository where the postlogistics module is (which is also only for Switzerland)

After followed this discussion OCA/delivery-carrier#413 (comment)

@yvaucher
Copy link
Member

Thus we might want to pull delivery_postlogitics here sigh

@yvaucher
Copy link
Member

is it necessary to have l10n_ch as a prefix? I mean the context is already there and AFAIK we don't depend on the l10n_ch chart of account.

OCA-git-bot added a commit that referenced this pull request Jul 7, 2022
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-613-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@leemannd
Copy link
Contributor

@StephaneMangin Is it possible to rebase?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 13, 2022
@github-actions github-actions bot closed this Jan 8, 2023
@yvaucher yvaucher removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 9, 2023
@yvaucher yvaucher reopened this Jan 9, 2023
@yvaucher
Copy link
Member

yvaucher commented Jan 9, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-613-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 9, 2023
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-613-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yvaucher
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@yvaucher The rebase process failed, because command git push --force StephaneMangin tmp-pr-613:12.0 failed with output:

remote: Permission to StephaneMangin/l10n-switzerland.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/StephaneMangin/l10n-switzerland/': The requested URL returned error: 403

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023
@github-actions github-actions bot closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants