-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][ADD] module l10n_ch_delivery_carrier_label_quickpac #613
Conversation
33a8856
to
d120ba1
Compare
<?xml version="1.0" encoding="utf-8"?> | ||
<odoo noupdate="1"> | ||
<record id="product_quickpac_service" model="product.product"> | ||
<field name="image" type="base64" file="delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="image" type="base64" file="delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/> | |
<field name="image" type="base64" file="l10n_ch_delivery_carrier_label_quickpac/static/img/quickpac-logo.jpg"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same fix to be applied in all places where the logo is referenced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done. Travis is restarted ^^
8cf6a71
to
baf7e27
Compare
f243e1b
to
8977805
Compare
8977805
to
7862ca1
Compare
558d151
to
faabf3a
Compare
This PR has the |
Question, why putting it here instead of delivery-carrier repository where the postlogistics module is (which is also only for Switzerland) |
After followed this discussion OCA/delivery-carrier#413 (comment) |
Thus we might want to pull delivery_postlogitics here sigh |
is it necessary to have |
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-613-by-yvaucher-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@StephaneMangin Is it possible to rebase? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
… to communication
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-613-by-yvaucher-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot rebase |
@yvaucher The rebase process failed, because command
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Previous PR : OCA/delivery-carrier#413
This carrier only delivers to Switzerland.
This is a new implementation for delivery carrier interaction with Quickpac.
This module has been based on oca/delivery-carrier/delivery_carrier_label_postlogistics. It uses an external python library that implements the Quickpac API through its OpenAPI generated client (Swagger Codegen, see: https://pypi.org/project/quickpac/)