Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_us_check_writing_address: Migration to 11.0 #25

Closed

Conversation

Sudarshan1607
Copy link

@Sudarshan1607 Sudarshan1607 commented Jul 24, 2018

#17

@pedrobaeza pedrobaeza mentioned this pull request Jul 24, 2018
11 tasks
@max3903 max3903 added this to the 11.0 milestone Jul 24, 2018
@max3903
Copy link
Sponsor Member

max3903 commented Jul 24, 2018

@Sudarshan1607 You also need to rebase on OCA/11.0:

git remote add oca git@github.com:OCA/l10n-usa.git
git fetch oca
git rebase -i oca/11.0

@coveralls
Copy link

coveralls commented Jul 24, 2018

Coverage Status

Coverage decreased (-38.3%) to 51.724% when pulling f9f790d on ursais:11.0-mig-us-check-writing-address into b6dfb53 on OCA:11.0.

@bodedra bodedra force-pushed the 11.0-mig-us-check-writing-address branch from d2f5cfe to f9f790d Compare July 25, 2018 05:38
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sudarshan1607 I have done some clean up and rebased it as per @max3903 suggested.

@Sudarshan1607 can you bring previous commit history?

CC @max3903

@max3903
Copy link
Sponsor Member

max3903 commented Jul 25, 2018

@bodedra , @Sudarshan1607 Let's get #8 merged first.

@max3903 max3903 requested review from bodedra and max3903 May 13, 2019 14:31
@max3903 max3903 changed the title [MIG] us_check_writing_address: Migration to 11.0 [MIG] l10n_us_check_writing_address: Migration to 11.0 May 13, 2019
@max3903 max3903 requested a review from murtuzasaleh May 21, 2019 22:22
@murtuzasaleh
Copy link
Member

@Sudarshan1607 Can you please do Squash your last 2 Commits?

'author': 'Ursa Information Systems, Odoo Community Association (OCA)',
'category': 'Localization/Checks Printing',
'maintainer': 'Ursa Information Systems',
'website': 'http://www.ursainfosystems.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,4 @@
# Copyright 2017 Ursa Information Systems <http://www.ursainfosystems.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Copyright from __init__.py file.

@gmader
Copy link

gmader commented May 23, 2019 via email

@max3903
Copy link
Sponsor Member

max3903 commented May 23, 2019

@murtuzasaleh I am not sure @Sudarshan1607 is available to fix this. Please continue on top of his branch and make your own pull request.

@max3903 max3903 closed this May 23, 2019
@murtuzasaleh
Copy link
Member

@murtuzasaleh I am not sure @Sudarshan1607 is available to fix this. Please continue on top of his branch and make your own pull request.

#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants