-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] l10n_us_check_writing_address: Migration to 11.0 #25
Conversation
@Sudarshan1607 You also need to rebase on OCA/11.0:
|
d2f5cfe
to
f9f790d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sudarshan1607 I have done some clean up and rebased it as per @max3903 suggested.
@Sudarshan1607 can you bring previous commit history?
CC @max3903
@bodedra , @Sudarshan1607 Let's get #8 merged first. |
@Sudarshan1607 Can you please do Squash your last 2 Commits? |
'author': 'Ursa Information Systems, Odoo Community Association (OCA)', | ||
'category': 'Localization/Checks Printing', | ||
'maintainer': 'Ursa Information Systems', | ||
'website': 'http://www.ursainfosystems.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add 'website': 'https://github.com/OCA/l10n-usa',
@@ -0,0 +1,4 @@ | |||
# Copyright 2017 Ursa Information Systems <http://www.ursainfosystems.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Copyright from __init__.py
file.
Please change any references from Ursa Information Systems to Open Source
Integrators
https://www.opensourceintegrators.com
…On Thu, May 23, 2019 at 6:09 AM Murtuza Saleh(SerpentCS) < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In l10n_us_check_writing_address/__manifest__.py
<#25 (comment)>:
> @@ -0,0 +1,20 @@
+# Copyright 2017 Ursa Information Systems <http://www.ursainfosystems.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+{
+ 'name': 'US Check Printing with Payee Address',
+ 'summary': 'Print US Checks',
+ 'version': '11.0.1.0.0',
+ 'license': 'AGPL-3',
+ 'author': 'Ursa Information Systems, Odoo Community Association (OCA)',
+ 'category': 'Localization/Checks Printing',
+ 'maintainer': 'Ursa Information Systems',
+ 'website': 'http://www.ursainfosystems.com',
Add 'website': 'https://github.com/OCA/l10n-usa',
------------------------------
In l10n_us_check_writing_address/__init__.py
<#25 (comment)>:
> @@ -0,0 +1,4 @@
+# Copyright 2017 Ursa Information Systems <http://www.ursainfosystems.com>
Remove Copyright from __init__.py file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25?email_source=notifications&email_token=ADEDV4UXN4QLHF7U2A5AELLPW2JPLA5CNFSM4FLUWET2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZP427A#pullrequestreview-241159548>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADEDV4TSWIQQQJ3ZSMXWL3TPW2JPLANCNFSM4FLUWETQ>
.
--
*GREGORY MADER*
PRESIDENT
*O:* 1.855.877.2377 EXT.700 <8558772377>
*M:* 909.499.1126 <9094991126>
*E:* GMader@OpenSourceIntegrators.com
<gmader@opensourceintegrations.com?subject=Email%20Reply>
1450 W. GUADALUPE RD. • GILBERT, AZ 85233
<https://www.opensourceintegrators.com/>
<https://www.magentointegrators.com/> <https://www.hadoopintegrators.com/>
<https://www.usaodoo.com/>
|
@murtuzasaleh I am not sure @Sudarshan1607 is available to fix this. Please continue on top of his branch and make your own pull request. |
|
#17