Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] l10n_us_gaap #53

Merged
merged 9 commits into from
Mar 2, 2020
Merged

[13.0][MIG] l10n_us_gaap #53

merged 9 commits into from
Mar 2, 2020

Conversation

JoanSForgeFlow
Copy link
Contributor

Standard l10n_us_gaap migration to v13.

cc ~ @ForgeFlow @LoisRForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @JordiBForgeFlow,
some modules you are maintaining are being modified, check this out!

@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Feb 18, 2020
Merged
@max3903 max3903 added this to the 13.0 milestone Feb 25, 2020
@max3903 max3903 linked an issue Feb 25, 2020 that may be closed by this pull request
Migration to version 13.0 #46
Closed
6 tasks
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 25, 2020
Closed
6 tasks
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 2, 2020
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow
Copy link
Contributor

@AdriaGForgeFlow Check last commit message 😉

@AdriaGForgeFlow
Copy link
Contributor

@AdriaGForgeFlow Check last commit message

👍

@AdriaGForgeFlow
Copy link
Contributor

@max3903 Ready to merge

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-53-by-JordiBForgeFlow-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4721f41 into OCA:13.0 Mar 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 68b8e3a. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 13.0-mig-l10n_us_gaap branch March 2, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees

@JoanSForgeFlow JoanSForgeFlow

Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

Migration to version 13.0
10 participants
@JoanSForgeFlow @OCA-git-bot @MiquelRForgeFlow @AdriaGForgeFlow @JordiBForgeFlow @AaronHForgeFlow @HviorForgeFlow @max3903 @dduarte-odoogap @oca-travis