This repository has been archived by the owner on May 16, 2024. It is now read-only.
[REF] install: pin coveralls version and supporting broken_uninstallable module #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
So, do you mean that the culprit is the version of coveralls? |
pedrobaeza
reviewed
Jan 22, 2020
| @@ -22,7 +22,6 @@ variables: | |||
| before_script: | |||
| - curl -sL https://deb.nodesource.com/setup_10.x | bash - | |||
| - apt-get install -y sudo postgresql-client expect-dev python-lxml nodejs python-dev python-pip build-essential libsasl2-dev python-dev libldap2-dev libssl-dev | |||
| - pip install coverage coveralls codecov | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
moylop260
force-pushed
the
oca-preinstall-moy
branch
from
1afa4e0
to
885597b
Compare
moylop260
changed the title
I saw something related and I just tested pin it But I didn't looking for more details. Maybe a recent changes incompatible. |
|
Wasn't this green previously? |
|
Yes, the coverage error was fixed but at the same time a new change was introduced in Odoo to log a new error: So, the new red is unrelated. |
moylop260
changed the title
- Related with OCA#626
moylop260
force-pushed
the
oca-preinstall-moy
branch
from
40923f4
to
cd2700a
Compare
After new logger.error from odoo/odoo@c5d6a39
moylop260
force-pushed
the
oca-preinstall-moy
branch
from
cd2700a
to
d143726
Compare
|
Now it is green... until now 😄 |
|
Hehe, let's merge it before turning again 😋 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #626
cc @yajo
And Supporting broken_uninstallable module
After new logger.error from odoo/odoo@c5d6a39