-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] template: Add full compatibility to show image from README.rst file #221
Conversation
We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo. Using the path "../{module_name}/{local_image_path}.{ext}" is compatible in all cases. You could follow the thread here: OCA/business-requirement#18 (comment)
I have tested the following syntaxes:
It seems that option one might do the trick |
👍 |
@@ -14,16 +14,16 @@ Installation | |||
|
|||
To install this module, you need to: | |||
|
|||
#. Do this ... | |||
# Do this ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this marker
It's nice to have a solution for this! Sad it won't work on pypi. |
We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo. Using the path "../{module_name}/{local_image_path}.{ext}" is compatible in all cases. You could follow the thread here: OCA/business-requirement#18 (comment)
👍 squashing both commits |
I dont have problem with use squash and merge button of github... |
I have tested the following syntaxes:
Option one seems not an option and I'd rather have option 3 + patch in OCB to accept both (or write both syntax in README) Has somebody contacted Odoo about that? |
IMHO if odoo is inconsistent between apps and module list this could be a issue https://github.com/odoo/odoo/issues/new Could you create it, please? |
link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?
Hi, |
what is the status of the PR? |
Odoo people is not replied us 😞 |
This is already handled in README generator, so closing. |
link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?
link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo.
Using the path
../{module_name}/{local_image_path}.{ext}
is compatible in all cases.You could follow the thread here: OCA/business-requirement#18 (comment)