[REF] template: Add full compatibility to show image from README.rst file #221

moylop260 · 2016-09-13T13:14:00Z

We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo.
Using the path ../{module_name}/{local_image_path}.{ext} is compatible in all cases.

You could follow the thread here: OCA/business-requirement#18 (comment)

We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo. Using the path "../{module_name}/{local_image_path}.{ext}" is compatible in all cases. You could follow the thread here: OCA/business-requirement#18 (comment)

elicoidal · 2016-09-13T13:35:40Z

I have tested the following syntaxes:

    .. figure:: ../business_requirement/static/img/bus_req_tree.png

in Odoo (settings/Modules/Local modules)
in Github
not tested in apps.odoo.com

    .. figure::  business_requirement/static/img/bus_req_tree.png

in Odoo (settings/Modules/Local modules)
in Github
not tested in apps.odoo.com

    .. figure:: static/img/bus_req_tree.png

in Odoo
in Github
not tested in apps.odoo.com

It seems that option one might do the trick

elicoidal · 2016-09-13T13:42:08Z

👍

pedrobaeza · 2016-09-13T13:46:03Z

template/module/README.rst

@@ -14,16 +14,16 @@ Installation

 To install this module, you need to:

-#. Do this ...
+#  Do this ...


Don't remove this marker

sbidoul · 2016-09-13T13:53:05Z

It's nice to have a solution for this! Sad it won't work on pypi.

We had a circular problem seeing the image from README.rst file in GitHub, apps.odoo.com or Odoo. Using the path "../{module_name}/{local_image_path}.{ext}" is compatible in all cases. You could follow the thread here: OCA/business-requirement#18 (comment)

pedrobaeza · 2016-09-13T19:38:13Z

👍 squashing both commits

moylop260 · 2016-09-13T20:11:09Z

I dont have problem with use squash and merge button of github...
But I can squash it locally too

elicoidal · 2016-09-14T00:59:59Z

I have bad news for you: apps.odoo.com is unhappy:

elicoidal · 2016-09-14T01:05:38Z

I have tested the following syntaxes:

    .. figure:: ../business_requirement/static/img/bus_req_tree.png

in Odoo (settings/Modules/Local modules)
in Github
in apps.odoo.com tested ([REF] template: Add full compatibility to show image from README.rst file #221 (comment))

    .. figure::  business_requirement/static/img/bus_req_tree.png

in Odoo (settings/Modules/Local modules)
in Github
not tested in apps.odoo.com

    .. figure:: static/img/bus_req_tree.png

in Odoo
in Github
in apps.odoo.com

~~It seems that option one might do the trick~~

Option one seems not an option and I'd rather have option 3 + patch in OCB to accept both (or write both syntax in README)

Has somebody contacted Odoo about that?

moylop260 · 2016-09-14T02:17:16Z

IMHO if odoo is inconsistent between apps and module list this could be a issue https://github.com/odoo/odoo/issues/new

Could you create it, please?

lmignon · 2016-09-14T05:49:05Z

odoo/odoo#8300

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

testing OCA/maintainer-tools#221

andriusl · 2017-05-25T21:03:00Z

Hi,
is there a way to make image load on all three platforms? github, Odoo, and Apps?
I'm currently using ../module_name/static/description/image.png approach, but this one does not work for Odoo Apps.

gurneyalex · 2018-02-03T15:17:39Z

what is the status of the PR?

moylop260 · 2018-02-06T20:16:14Z

Odoo people is not replied us 😞
odoo/odoo#8300 (comment)

pedrobaeza · 2019-01-07T17:18:39Z

This is already handled in README generator, so closing.

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

testing OCA/maintainer-tools#221

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

testing OCA/maintainer-tools#221

[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221

moylop260 added the needs review label Sep 13, 2016

moylop260 self-assigned this Sep 13, 2016

moylop260 mentioned this pull request Sep 13, 2016

Improve the README and added functional workflow OCA/business-requirement#18

Merged

3 tasks

moylop260 changed the title ~~[REF] template: Add full compatibility of figure in README.rst file~~ [REF] template: Add full compatibility to show image from README.rst file Sep 13, 2016

pedrobaeza reviewed Sep 13, 2016
View reviewed changes

lmignon mentioned this pull request Sep 14, 2016

Images in module description not properly displayed on app.store and in the list of local modules in an odoo instance odoo/odoo#8300

Closed

elicoidal added a commit to OCA/business-requirement that referenced this pull request Sep 15, 2016

Update image link as they where not visible in app

2a23db3

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

elicoidal mentioned this pull request Sep 15, 2016

Update image link as they where not visible in app OCA/business-requirement#21

Merged

1 task

elicoidal added a commit to OCA/business-requirement that referenced this pull request Sep 15, 2016

Added double image handling

c933bbb

testing OCA/maintainer-tools#221

lasley approved these changes Jan 2, 2018

View reviewed changes

pedrobaeza closed this Jan 7, 2019

ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019

Update image link as they where not visible in app

be82a1a

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019

Added double image handling

a10d308

testing OCA/maintainer-tools#221

victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019

Update image link as they where not visible in app

6c80550

link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one?

victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019

Added double image handling

4d2a927

testing OCA/maintainer-tools#221

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REF] template: Add full compatibility to show image from README.rst file #221

[REF] template: Add full compatibility to show image from README.rst file #221

moylop260 commented Sep 13, 2016

elicoidal commented Sep 13, 2016

elicoidal commented Sep 13, 2016

pedrobaeza Sep 13, 2016

sbidoul commented Sep 13, 2016

pedrobaeza commented Sep 13, 2016

moylop260 commented Sep 13, 2016

elicoidal commented Sep 14, 2016

elicoidal commented Sep 14, 2016

moylop260 commented Sep 14, 2016

lmignon commented Sep 14, 2016

andriusl commented May 25, 2017

gurneyalex commented Feb 3, 2018

moylop260 commented Feb 6, 2018

pedrobaeza commented Jan 7, 2019

[REF] template: Add full compatibility to show image from README.rst file #221

[REF] template: Add full compatibility to show image from README.rst file #221

Conversation

moylop260 commented Sep 13, 2016

elicoidal commented Sep 13, 2016

elicoidal commented Sep 13, 2016

pedrobaeza Sep 13, 2016

Choose a reason for hiding this comment

sbidoul commented Sep 13, 2016

pedrobaeza commented Sep 13, 2016

moylop260 commented Sep 13, 2016

elicoidal commented Sep 14, 2016

elicoidal commented Sep 14, 2016

moylop260 commented Sep 14, 2016

lmignon commented Sep 14, 2016

andriusl commented May 25, 2017

gurneyalex commented Feb 3, 2018

moylop260 commented Feb 6, 2018

pedrobaeza commented Jan 7, 2019