Improve the README and added functional workflow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase
Modified the openerp.py too remove unused images
@moylop I have a problem with travis that my rst editor doesnot spot (enumerated lists). Can you help me?
@moylop, I have an error (title too short) which I dont know where it comes from... Thanks for your help!
|
Pylint reports some RST issues. |
|
@dreispt Yes, I have seen that but my rst editor doesnot complain and output is OK. |
|
Hummm: I have to investigate why images are not displayed in the README in settings/local modules |
|
The enumerate list from section Currently: Usage
=====
Simple BR
---------
1. Define the header information
* Master Project (Partner is the one related to the master project)
...
.. figure:: static/img/bus_req_tags2.png
:width: 600 px
:alt: THIS ITEM IS ROOT
2. Input the customer story, scenario and gap (simple html editor with image and text)Should be Usage
=====
Simple BR
---------
1. Define the header information
* Master Project (Partner is the one related to the master project)
...
.. figure:: static/img/bus_req_tags2.png
:width: 600 px
:alt: THIS ITEM ISN'T ROOT (because have prefix spaces)
1. Input the customer story, scenario and gap (simple html editor with image and text) |
|
@moylop260 thanks for the feedback. |
|
@victormartinelicocorp I have finally fixed the rst issues (thanks @moylop260 ). |
|
Images in README are not displayed in Odoo / settings/ local modules. |
|
|
||
| * Master Project (Partner is the one related to the master project) |
There was a problem hiding this comment.
Indent correctly this at the level of D
|
I remember @eLBati was able to load images both in GitHub, Apps and in Odoo. Lorenzo, can you tell us how you did it? |
@pedrobaeza done but seems not enough |
|
@pedrobaeza I have come across an annoying situation here. I have tested locally and come across a solution that somehow contradicts some directive I was given earlier and I am confused now. I had to use:
(including the name of the module) This is the only way I found to have it display in settings/Modules/local modules. but obviously that doesnot display in my rst editor and GH... |
ruter-lyu
pushed a commit
to ruter-lyu/business-requirement
that referenced
this pull request
Mar 15, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
ruter-lyu
pushed a commit
to ruter-lyu/business-requirement
that referenced
this pull request
Mar 15, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 4, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 6, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
pedrobaeza
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 26, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 26, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jul 25, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Aug 9, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Aug 19, 2019
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jan 24, 2020
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jan 27, 2020
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 3, 2020
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 5, 2020
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 30, 2020
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Oct 14, 2021
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Oct 14, 2021
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 11, 2021
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 15, 2021
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 15, 2021
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
MosabWadea
pushed a commit
to MosabWadea/business-requirement
that referenced
this pull request
Mar 5, 2022
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
MosabWadea
pushed a commit
to MosabWadea/business-requirement
that referenced
this pull request
Mar 5, 2022
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
bizzappdev
pushed a commit
to BizzAppDev-Systems/business-requirement
that referenced
this pull request
Mar 4, 2023
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
AntoniRomera
pushed a commit
to AntoniRomera/business-requirement
that referenced
this pull request
Jul 4, 2023
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
dreispt
pushed a commit
to dreispt/business-requirement
that referenced
this pull request
Apr 27, 2024
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
1 task
dreispt
pushed a commit
to dreispt/business-requirement
that referenced
this pull request
Apr 27, 2024
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg
NachoAlesLopez
pushed a commit
to NachoAlesLopez/business-requirement
that referenced
this pull request
Apr 28, 2024
[IMP] business_requirement * Improved and unified the README for the br_deliverable module * Modified the openerp.py too remove unused images * Finetuning * Remove oca.cfg Update image link as they where not visible in app link to this issue: OCA/maintainer-tools#221 @ pedro can we FT this one? Added double image handling testing OCA/maintainer-tools#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dreispt This will become the base introduction for all modules
Coverage remained the same at 90.991% when pulling c20439e on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 4fce62c on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 2300dfd on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 2300dfd on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 15043e0 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 15043e0 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 180e9c0 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 180e9c0 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling f8b19ce on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling f8b19ce on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 459293e on elicoidal:8.0 into a598784 on OCA:8.0.
I just dont know how to interpret the error: I know it is about the enumerated list in the procedure but cannot find the reason ( @moylop260 ?)
Usage - Simple BRsection have rootfigureelements between items.Currently:
Should be
Interesting: let me investigate and test a little bit more (diving into the subtleties of rst)
Coverage remained the same at 90.991% when pulling f8b15f9 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling d024256 on elicoidal:8.0 into a598784 on OCA:8.0.
Can you try to tidy up the rest of the warnings in Travis?
Path seems OK: is there any limitation/different treatment in v8?
I just don't know where to look anymore ( @moylop260 @pedrobaeza any idea)
Coverage remained the same at 90.991% when pulling 1bbe786 on elicoidal:8.0 into a598784 on OCA:8.0.
@pedrobaeza done but seems not enough
Coverage remained the same at 90.991% when pulling 86394dd on elicoidal:8.0 into a598784 on OCA:8.0.
I have tested locally and come across a solution that somehow contradicts some directive I was given earlier and I am confused now.
I had to use:
Coverage remained the same at 90.991% when pulling e8d7807 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling e8d7807 on elicoidal:8.0 into a598784 on OCA:8.0.
I prefer the first one so I will revert the changes I made just now.
A stupid solution is to include both syntaxes: they will not display at the same time so the output should be OK.
@pedrobaeza
Coverage remained the same at 90.991% when pulling 4ee945a on elicoidal:8.0 into a598784 on OCA:8.0.
Maybe, we could use:
.. figure:: ../business_requirement/static/img/bus_req_tree.pngNotice the
..in the image path in order to force show in all cases.I have no idea where: any pointer?
and get this:
both options are valid for Odoo AND my rst editor does like the first option
Coverage remained the same at 90.991% when pulling 762ed44 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling ac7da34 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling ac7da34 on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 1da0c5d on elicoidal:8.0 into a598784 on OCA:8.0.
Coverage remained the same at 90.991% when pulling 1da0c5d on elicoidal:8.0 into a598784 on OCA:8.0.
Merging...
The good news if the
squash and mergebutton of github the branch stable have just 1 commit and we don't need a rebase-squash process before of merge itD