[IMP] Adding exception section for good practice #252
Conversation
| try: | ||
| sentences | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Remove pass
If you use a sentence after pass then is not need it
| If you really need to use the `pass` consider logging that exception | ||
|
|
||
| ```python | ||
| try: |
There was a problem hiding this comment.
Might want to reduce the indentation level by one, this is double indented in the example block right now
There was a problem hiding this comment.
Okay, thanks for your comment!
|
@lmignon Are you agree with this guideline (and future check)? |
|
@yajo @pedrobaeza Your feedback is welcome |
|
In some cases It could be useful to properly log the exception with the stacktrace.. (That depends of the context.) try:
sentences
except:
_logger.debug('Why the exception is safe....', exc_info=1)) |
| try: | ||
| sentences | ||
| except: | ||
| _logger.debug('Pass') |
There was a problem hiding this comment.
Please switch to a lowercase L. _logger
There was a problem hiding this comment.
I don't understand, what uppercase L are you referring?
There was a problem hiding this comment.
Wow ok sorry, this is totally just something with Github display & not something you did (it's a lowercase l looking at the code in IDE).
Just so you know I'm not crazy though, this looks like some sort of uppercase unicode L derivate. Something with the font of the italics I guess:
There was a problem hiding this comment.
Ok! dont worry
Thanks
There was a problem hiding this comment.
Do you have a auto-translator enabled from your browser?
|
@JesusZapata |
|
@moylop260 @lmignon Done! |
|
@moylop260 |
The
passinto block except is not a good practice!By including the
passwe assume that our algorithm can continue to function after the exception occurredIf you really need to use the
passconsider logging that exception