add "ready to merge" label #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Sep 22, 2018
elicoidal
reviewed
Sep 23, 2018
| @@ -28,6 +28,7 @@ | |||
| 'work in progress': '0052cc', | |||
| 'wontfix': 'ffffff', | |||
| 'migration': 'd4c5f9', | |||
| 'ready to merge': 'bfdadc', | |||
There was a problem hiding this comment.
What is the difference with approved?
Do we have a document with the suggested usage of each label?
There was a problem hiding this comment.
@elicoidal approved is fine with me. I had not noticed it.
I actually used ready to merge from #346, as a first PR to OCA/oca-github-bot#1
There was a problem hiding this comment.
I would keep either one or the other (but could keep both if there is enough reason for it)
@sbidoul
There was a problem hiding this comment.
@elicoidal after further thinking, I think both are useful: approved when all approvals are ok. Then ready to merge when other conditions (like the PR age are met). I updated OCA/oca-github-bot#1 with this concept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.