[ADD] task to set ready to merge label #1
Conversation
sbidoul
force-pushed
the
ready-to-merge-label
branch
from
b4ac4d1
to
541c5e1
Compare
|
|
||
|
|
||
| APPROVALS_REQUIRED = 2 | ||
| MIN_PR_AGE = 5 # days |
There was a problem hiding this comment.
Maybe we could use something like that to avoid counting down on Saturdays and Sundays by default.
https://gist.github.com/JosefJezek/275b2c667698aabd6969
There was a problem hiding this comment.
Yes, that would be a nice improvement. I'll try to make the basic version work first, then we can improve.
There was a problem hiding this comment.
@damdam-s if you think it's important to not count week-ends in the 5 days, can you open an issue for discussion?
| _logger = getLogger(__name__) | ||
|
|
||
|
|
||
| APPROVALS_REQUIRED = 2 |
There was a problem hiding this comment.
Maybe this value of 2 can be a fallback for a customized value on each repository.
This would allow more flexiblity and this kind" of rule could be managed by the PSC of the repo they are responsible of.
There was a problem hiding this comment.
The question would be where to configure these parameters per repo. In any case, these label are only advisory.
sbidoul
force-pushed
the
ready-to-merge-label
branch
from
bd1c10a
to
3acc6c7
Compare
|
I reworked the logic to make a cron unncessary and only react on PR events. |
sbidoul
force-pushed
the
ready-to-merge-label
branch
2 times, most recently
from
806a1ff
to
11d018c
Compare
sbidoul
force-pushed
the
ready-to-merge-label
branch
from
11d018c
to
1064d27
Compare
|
@OCA/board this PR is deployed since Saturday. |
|
This has been running fine for a week, was discussed on the board and approved by @max3903 so merging. |
|
@sbidoul the only problem I see with this is that when we approve a PR with 2 approvals, but not 5 days, when the 5 days have passed, unless you make an additional comment or any action on the PR, there's no notification of ready to merge. |
|
@pedrobaeza it is handled correctly: there is a task running hourly to set the ready to merge tag. So if all conditions are met, the ready to merge tag will appear 5 days after creation of the PR. |
|
Ah, great, I thought that you removed all crons and only acts on hooks. |
Improve the KO message on how to proceed for CLA
* function to check if a user can git push * webhook on pull request comments to parse and run /ocabot commands
Extracted from OCA/maintainer-tools#346
TODO
cron to run the task nightly on all repos(or maybe not: we would quickly explode the API rate limit)