mgmtsystem_audit progress #143

naousse · 2016-06-24T00:14:33Z

No description provided.

dreispt · 2016-06-24T13:00:50Z

mgmtsystem_audit/models/mgmtsystem_audit.py

-        'is_conformed': False
-    }
+
+    name = fields.Char('Question', size=300, required=True)


remove size from char fields

dreispt · 2016-06-24T14:56:30Z

mgmtsystem_audit/models/mgmtsystem_audit.py

+
+    closing_date = fields.Datetime('Closing Date', readonly=True)
+
+    age = fields.Integer('Age', readonly=True, compute='_get_age')


_compute_age

dreispt · 2016-07-18T08:16:05Z

@naousse can you address my comments please?

naousse · 2016-07-18T14:46:30Z

@DreiPst i Will do it. I'm fixing some problem on report. Please there is special version of wkhtmltopdf I can use to work on reports. I tested many but the output is not good.

dreispt · 2016-07-22T12:29:53Z

CI is red

naousse · 2016-07-28T16:21:00Z

mgmtsystem_audit/wizard/copy_verification_lines.py

                'procedure_id': line.procedure_id.id,
                'is_conformed': False,
-            }, context=context)
+            })
        return {'type': 'ir.actions.act_window_close'}


@dreispt
Please , here is the model of a wizard inside this module that i migrate, it is not working and i don't know what's wrong. Please i want you to check if you can figure out what is not working.
That's the error i have
File "/home/odoo/odoo-dev/odoo/openerp/api.py", line 382, in old_api
return downgrade(recs, result, _args, *_kwargs)
File "/home/odoo/odoo-dev/odoo/openerp/api.py", line 273, in
return lambda self, _args, *_kwargs: downgrade(args[0])
File "/home/odoo/odoo-dev/odoo/openerp/models.py", line 4954, in
@api.returns('self', lambda value: value.id)
AttributeError: 'dict' object has no attribute 'id'

This error is fixed

naousse · 2016-07-28T16:21:49Z

@dreispt, @max3903
Please you can review this now

dreispt · 2016-07-28T22:42:14Z

mgmtsystem_audit/models/mgmtsystem_audit.py

@@ -20,163 +20,265 @@
 ##############################################################################

 from openerp.tools.translate import _


from openerp import _

dreispt · 2016-07-28T22:49:37Z

mgmtsystem_audit/models/mgmtsystem_audit.py

+        for id in self.line_ids:
+            number = number + 1
+        self.number_of_questions_in_verification_list = number
+        return number


dreispt · 2016-07-28T23:00:44Z

@max3903 Idea: can Verification Lists be replaced by standard Surveys?

max3903 · 2016-07-28T23:02:09Z

@dreispt I think it can, yes.

dreispt · 2016-07-28T23:04:37Z

Let's not complicate this PR though: that can go in a future one.
Maybe we should keep the old code to allow printing "legacy" verification lists.

max3903 · 2016-07-28T23:05:26Z

@dreispt Let's keep this idea out of the scope and in an issue ;)

dreispt · 2016-07-29T13:31:00Z

mgmtsystem_audit/models/mgmtsystem_audit.py

        return self.write({'state': 'done',
-                           'closing_date': time.strftime(DATETIME_FORMAT),
-                           'number_of_days_to_close': number_of_days_to_close})
+                           'closing_date': time.strftime(DATETIME_FORMAT)})


It's best to use fields.Datetime.now()

max3903 · 2016-07-29T14:27:09Z

@naousse Needs rebase.

max3903 · 2016-07-30T00:48:15Z

@naousse Few comments:

Separate the verification line class in its own file. One class per file.
If we delete the audit, we want to remove the verification lines, but keep the procedures. Not sure the ondelete are correct.
Audits menu items should be below Nonconformities

In the Verification List report (See attached):

Confidentially --> Confidentiality
Date value is not aligned with the reference and confidentiality ones
Columns content is shifted to the right. Comments column should be empty.

In the demo data:

Convert the Strong points and To improve points values into HTML

naousse · 2016-08-01T12:34:51Z

@max3903
Please there are conflicts in this branch. Please how can we solve it. I don't know where they come

naousse · 2016-08-01T12:47:31Z

@max3903
Please maxime, can you explain me this recommendation,
Columns content is shifted to the right. Comments column should be empty
The new report provide the same result as the former.

max3903 · 2016-08-01T15:57:36Z

Superseeded by #152

mgmtsystem_audit progress

4509b85

dreispt reviewed Jun 24, 2016
View reviewed changes

max3903 added the needs fixing label Jun 24, 2016

max3903 added this to the 9.0 milestone Jun 24, 2016

dreispt reviewed Jun 24, 2016
View reviewed changes

pedrobaeza mentioned this pull request Jun 24, 2016

Migration to version 9.0 #92

Closed

30 tasks

improving report

d5766fc

Improving mgmtsystem_audit migration

08ce316

Many improvements

27bdb7c

naousse reviewed Jul 28, 2016
View reviewed changes

Wizard error fixed

e041e54

dreispt added needs review and removed needs fixing labels Jul 28, 2016

dreispt reviewed Jul 28, 2016
View reviewed changes

naousse added 2 commits July 29, 2016 03:49

Improving code base on @DreiPst comment

30ee0eb

Removing unused datetime import

69ad1ad

dreispt reviewed Jul 29, 2016
View reviewed changes

naousse added 4 commits July 29, 2016 11:12

mgmtsystem_audit migration to odoo 9.0

7d0778f

fields.Datetime.now() used to get current time

5d41ea1

tests added

3d37501

improving code coverages

8dd14fe

max3903 added needs fixing and removed needs review labels Jul 30, 2016

Applying some Maxime Recommendation

d574392

verification list report is now correct

a837358

max3903 closed this Aug 1, 2016

max3903 mentioned this pull request Aug 1, 2016

[MIG] mgmtsystem_audit #152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgmtsystem_audit progress #143

mgmtsystem_audit progress #143

naousse commented Jun 24, 2016

dreispt Jun 24, 2016

dreispt Jun 24, 2016

dreispt commented Jul 18, 2016

naousse commented Jul 18, 2016

dreispt commented Jul 22, 2016

naousse Jul 28, 2016 •

edited

Loading

naousse Jul 28, 2016

naousse commented Jul 28, 2016 •

edited

Loading

dreispt Jul 28, 2016

dreispt Jul 28, 2016

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016 •

edited

Loading

dreispt Jul 29, 2016

max3903 commented Jul 29, 2016

max3903 commented Jul 30, 2016

naousse commented Aug 1, 2016

naousse commented Aug 1, 2016

max3903 commented Aug 1, 2016


		closing_date = fields.Datetime('Closing Date', readonly=True)

		age = fields.Integer('Age', readonly=True, compute='_get_age')

		@@ -20,163 +20,265 @@
		##############################################################################

		from openerp.tools.translate import _

mgmtsystem_audit progress #143

mgmtsystem_audit progress #143

Conversation

naousse commented Jun 24, 2016

dreispt Jun 24, 2016

Choose a reason for hiding this comment

dreispt Jun 24, 2016

Choose a reason for hiding this comment

dreispt commented Jul 18, 2016

naousse commented Jul 18, 2016

dreispt commented Jul 22, 2016

naousse Jul 28, 2016 • edited Loading

Choose a reason for hiding this comment

naousse Jul 28, 2016

Choose a reason for hiding this comment

naousse commented Jul 28, 2016 • edited Loading

dreispt Jul 28, 2016

Choose a reason for hiding this comment

dreispt Jul 28, 2016

Choose a reason for hiding this comment

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016 • edited Loading

dreispt Jul 29, 2016

Choose a reason for hiding this comment

max3903 commented Jul 29, 2016

max3903 commented Jul 30, 2016

naousse commented Aug 1, 2016

naousse commented Aug 1, 2016

max3903 commented Aug 1, 2016

naousse Jul 28, 2016 •

edited

Loading

naousse commented Jul 28, 2016 •

edited

Loading

max3903 commented Jul 28, 2016 •

edited

Loading