Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] mgmtsystem_audit #152

Merged
merged 3 commits into from
Aug 2, 2016
Merged

[MIG] mgmtsystem_audit #152

merged 3 commits into from
Aug 2, 2016

Conversation

max3903
Copy link
Member

@max3903 max3903 commented Aug 1, 2016

Fixes #143 conflicts.

@max3903 max3903 added this to the 9.0 milestone Aug 1, 2016
@max3903 max3903 mentioned this pull request Aug 1, 2016
@pedrobaeza pedrobaeza mentioned this pull request Aug 1, 2016
30 tasks
@max3903
Copy link
Member Author

max3903 commented Aug 1, 2016

@naousse Few comments:

  • Separate the verification line class in its own file. One class per file.
  • If we delete the audit, we want to remove the verification lines, but keep the procedures. Not sure the ondelete are correct.
  • Audits menu items should be below Nonconformities

In the Verification List report (See attached):

  • Confidentially --> Confidentiality
  • Date value is not aligned with the reference and confidentiality ones
  • Columns content is shifted to the right. Comments column should be empty.

In the demo data:

  • Convert the Strong points and To improve points values into HTML

@max3903
Copy link
Member Author

max3903 commented Aug 1, 2016

👍

1 similar comment
@dreispt
Copy link
Member

dreispt commented Aug 2, 2016

👍

@max3903 max3903 merged commit 8635941 into OCA:9.0 Aug 2, 2016
@max3903 max3903 deleted the 9.0-mgmtsystem_audit branch August 2, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants