[REF] 8.0 mgmtsystem nonconformity

[llacroix]

Removed base_status dependency and reimplemented some of the methods that were missing to keep the cases working.

depends on

• [REF] 8.0 mgmtsystem_action #22
• [REF] 8.0 document page procedure #35
  • [REF] Ported document_page_work_instructions #26
    • [wip] 8.0 document page approval knowledge#30

[bwrsandman]

Please remove this commented line

[bwrsandman]

As a general rule, unless the classes are very small (case of one2many). We strongly recommend you split python/xml files by model involved.

https://lists.launchpad.net/openerp-community/msg06955.html

[llacroix]

_constraint not present in mgmtsystem_nonconformity_origin.py. yet the code is almost the same. We could technically subclass both class and clone the implementation or just add a type instead of copying code.

[bwrsandman]

Good catch on the constraint.

I haven't done this, but I think to clone a class you can do this:

class mgmtsystem_nonconformity_origin(models.Model):
    _name = "mgmtsystem.nonconformity.origin"
    _inherit = "mgmtsystem.nonconformity.cause"

If that doesn't work, you can use an abstract model and then subclass from that

[llacroix]

Yes, but I'd rather subclass them as origin aren't causes and causes aren't origin. If it's fine to inherit only for the structure only then it could be fine but if there is a way to get all origins and it will catch all causes too it won't make sense.

[bwrsandman]

depends on #35

[bwrsandman]

pep8:

./mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py:79:8: E121 continuation line under-indented for hanging indent

[dreispt]

Could we have this to not depend on document_page_procedure?
We may want to manage NCs is Odoo but prefer to manage Procudure Docs elsewhere.

[max3903]

@dreispt having a dependency on document_page_procedure does not necessarily mean you manage your documentation content in Odoo. We use it as a list to reference the content in another application. The day we want to put everything in Odoo, we just have to transfer the content and drop the other application.

If you want to drop the dependency, you will have to create a new field to provide the list of procedures (quality), environmental aspects (environment), and other thing in other systems.

I am sure you will agree with me that any Management Systems software should come with a documentation system, so why Odoo should be different here.

[dreispt]

name should be a human readable text

[bwrsandman]

Or it can be ommited

[bwrsandman]

@max3903, @dreispt please test

[dreispt]

Thanks @bwrsandman !

[dreispt]

You can use: default=get_default_stage

[bwrsandman]

I use lambda so get_default_stage can be overriden. AFAIK setting default to a member function directly does not allow it to be overriden the way that a call to self. does.

[bwrsandman]

@dreispt Most other porting PRs are dependent on this one, do you think your adjustments can be made after merging this?

[max3903]

I think we added a name field on version 7 and I don't see it here.

Otherwise
👍

[ghost]

Hi! @dreispt, @max3903

May I include Spanish translation in this branch 8.0-mgmtsystem_nonconformity ?

[max3903]

@gs-clearcorp Sure!

[ghost]

PR here savoirfairelinux#18

[dreispt]

@bwrsandman @max3903 Good enough today is better than perfect tomorrow, so yes, go ahead.
@max3903 I won't be able do to work on this, so maybe the idea can be put into the roadmap.

[max3903]

@dreispt not sure what you want to add, but here it is #84

👍

[dreispt]

👍