Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] 8.0 mgmtsystem nonconformity claim #33

Merged

Conversation

llacroix
Copy link
Contributor

Marked as installable and no other change were required for the port. Doesn't yet use API version 8

@bwrsandman
Copy link

Please:

  • Split mgmtsystem_nonconformity.py to mgmtsystem_nonconformity.py and mgmtsystem_nonconformity_type.py
  • Split mgmtsystem_nonconformity.xml to mgmtsystem_nonconformity_view.xml and mgmtsystem_nonconformity_type_view.xml
  • Rename mgmtsystem_nonconformity_data.xml to mgmtsystem_nonconformity_type_data.xml

@bwrsandman bwrsandman added this to the 8.0 milestone Nov 27, 2014
@llacroix llacroix force-pushed the 8.0-mgmtsystem_nonconformity_claim branch from 55776be to 3cccb50 Compare April 1, 2015 09:35
@bwrsandman bwrsandman closed this Aug 4, 2015
@bwrsandman bwrsandman reopened this Aug 4, 2015
@@ -0,0 +1,3 @@
# -*- encoding: utf-8 -*-
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encoding works too

@bwrsandman
Copy link

openerp.addons.mgmtsystem_nonconformity.tests.test_cause: test_create_cause is failing due to a not null constraint, this could be fixed by adding a name or it could be the fact that another module added a SQL level constraint, which is tougher to fix

@max3903 max3903 force-pushed the 8.0-mgmtsystem_nonconformity_claim branch from 3cccb50 to a36e30d Compare August 5, 2015 18:27
@max3903 max3903 mentioned this pull request Aug 5, 2015
26 tasks
_description = "Feedback and Nonconformities"
_columns = {
'type_id': fields.many2one('mgmtsystem.nonconformity.type', 'Type'),
}
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to remove this feature?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is good. It is pointing to another file with this code.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it is. I was twice blind.

@dreispt
Copy link
Sponsor Member

dreispt commented Aug 7, 2015

👍

1 similar comment
@max3903
Copy link
Sponsor Member

max3903 commented Aug 7, 2015

👍

max3903 pushed a commit that referenced this pull request Aug 7, 2015
…mity_claim

[REF] 8.0 mgmtsystem nonconformity claim
@max3903 max3903 merged commit 6024603 into OCA:8.0 Aug 7, 2015
@max3903 max3903 deleted the 8.0-mgmtsystem_nonconformity_claim branch August 7, 2015 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants