Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] mrp_flattened_bom_xlsx #70

Merged
merged 11 commits into from Jan 16, 2020
Merged

[13.0][MIG] mrp_flattened_bom_xlsx #70

merged 11 commits into from Jan 16, 2020

Conversation

AdriaGForgeFlow
Copy link

Standard migration of module mrp_flattened_bom_xlsx to v13.

cc ~ @ForgeFlow

LoisRForgeFlow
LoisRForgeFlow approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HviorForgeFlow
HviorForgeFlow approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-70-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 16, 2020
@OCA-git-bot
Merge PR #70 into 13.0
aec6b18 
Signed-off-by LoisRForgeFlow
@OCA-git-bot OCA-git-bot merged commit 656a19b into OCA:13.0 Jan 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9edca8d. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 13.0-mig-mrp_flattened_bom_xlsx branch January 16, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AdriaGForgeFlow @OCA-git-bot @LoisRForgeFlow @HviorForgeFlow @JoanSForgeFlow @oca-travis