Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] quality_control_oca: inspection access buttons in product forms #1056

Closed

Conversation

dalonsod
Copy link
Contributor

This improvement adds form buttons for product and product variants, so inspections for product variants can be directly accessed. Also, when an inspection is created within that form/tree views, where possible, product is auto-filled.

@dalonsod
Copy link
Contributor Author

@cubells @enriquemartin @angelmoya could you review?

When merged, I'll port it to v16

@dalonsod
Copy link
Contributor Author

@lk-eska @gurneyalex could you review? Thanks!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 24, 2023
This improvement adds form buttons for product and product variants, so
inspections for product variants can be directly accessed.
Also, when an inspection is created within that form/tree views, where possible,
product is auto-filled.
@dalonsod dalonsod force-pushed the 15.0-imp-quality_control_oca-prodform branch from 4be5d02 to f3dc5d1 Compare November 25, 2023 11:17
@dalonsod dalonsod force-pushed the 15.0-imp-quality_control_oca-prodform branch from f3dc5d1 to 0a26ef8 Compare November 25, 2023 11:20
@dalonsod
Copy link
Contributor Author

Tests seem to fail due to stock_picking_product_kit_helper addon. I've recently done a rebase, what could I do to solve it?

@pedrobaeza
Copy link
Member

It seems one module is doing move_line_raw_ids non stored, or there's a non-appropriate search on that field.

About the default_object_id, maybe you can use active_id.

@dalonsod
Copy link
Contributor Author

dalonsod commented Dec 4, 2023

It seems one module is doing move_line_raw_ids non stored, or there's a non-appropriate search on that field.

This test error is reproduced in #1149 , an addon with no tests. How could we solve it? I've looked for any search across move_line_raw_ids in other addons and I haven't found anything. This error should stop merges in this repo in general?

About the default_object_id, maybe you can use active_id.

Yes, I tried it before updating this PR, but it didn't work. Thanks for the point anyway 😀

Copy link

github-actions bot commented Apr 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 7, 2024
@github-actions github-actions bot closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants