Move refresh just before _check (fixes #124 for multi level BoM as well) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # introduces a weird behavior on the next call, provoking an error | ||
| procurement.production_id.sudo().refresh() | ||
| return super(ProcurementOrder, self)._check( | ||
| cr, uid, procurement, context=context) |
|
So it seems that you need the refresh on both places? Please squash all the commits in one. |
|
LGTM 👍 |
levkar
force-pushed
the
real_cost_refresh_fix
branch
from
39c4bb4
to
46f59d9
Compare
|
Figuring out squashing took more time than the fix :) |
|
Is this still needed with recent revisions? |
|
I haven't tested with final version but I cannot see any PR which fixes this problem and later than this PR. Seems like nobody is using multi level BoM :) |
|
@oihane @anajuaristi maybe you can check? |
|
ping @oihane @anajuaristi |
|
Closing as there are unresolved comments for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124 for multi level BoM's.