Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] add a new module to allow planner changing the supply method on procurement order level #15

Closed
wants to merge 3 commits into from

Conversation

duanyp1991
Copy link
Member

[ADD] add a new module to allow planner changing the supply method on procurement order level
Changes to be committed:

new file:   procurement_supply_method/__init__.py
new file:   procurement_supply_method/__openerp__.py
new file:   procurement_supply_method/procurement.py
new file:   procurement_supply_method/procurement_supply_method_views.xml

… the procurement order level.

 Changes to be committed:
	new file:   procurement_supply_method/__init__.py
	new file:   procurement_supply_method/__openerp__.py
	new file:   procurement_supply_method/procurement.py
	new file:   procurement_supply_method/procurement_supply_method_views.xml
'website': 'www.openerp.net.cn',
'category': 'Generic Modules/Production',
'depends': ['procurement', 'sale', 'mrp', 'purchase'],
'description': """

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clonedagain Hi, The template you provided is in the syntax of *rst, but the structure is quite good, I'll make another commit to change the description of the module, thanks a lot!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are targeting v7, you can use RST in the description and it should be rendered correctly.
Later when you migrate the module to v8, remember to replace the description in this file by a separate README.rst file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clonedagain Okay, thanks for the tip! :)

@clonedagain
Copy link

Does that mean the person in charge must review/confirm each procurement before they can run?

Would you care to add a concrete use case for this module in the description?

{
'name': 'Procurement Improvement - supply method',
'version': '1.0',
'author': 'Elico Corp',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add "Odoo Community Association (OCA)"

    * improvement on description in file: __openerp__.py
        - using communinty template
        - adding business case
    * add maintainer:OCA
 Changes to be committed:
	modified:   procurement_supply_method/__init__.py
	modified:   procurement_supply_method/__openerp__.py
	new file:   procurement_supply_method/mrp.py
	modified:   procurement_supply_method/procurement.py
	new file:   procurement_supply_method/sale.py
@duanyp1991
Copy link
Member Author

@gurneyalex I have added the OCA maintainer.:)
@clonedagain I have improved the description and added one business case. About the flask8 checking, the number of characters of one line should be less than 100 instead of 79, no?
Thanks.

@gurneyalex
Copy link
Member

@duanyp1991 we are using 79 for all addons, after a long discussion. Unless PEP8 has been updated, we are sticking to this.

Thanks for updating the author.

on the procurement order level instead of having two products with different
supply methods.

Please note that this module re-define the field: procure_method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/define/defines/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gurneyalex Thanks! already corrected.

	* Fix pep8
	* Add README.rst file
	* change typo
@pedrobaeza
Copy link
Member

@duanyp1991 are you still interested in this PR?

@LoisRForgeFlow
Copy link
Contributor

No answer. Closing, please feel free to reopen.

dreispt pushed a commit to burroaktoolinc/manufacture that referenced this pull request May 29, 2023
[FIX] mrp_account_analytic_wip: Fixed planned quantities calculation according to reference bom and work order values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants